Opened 12 years ago
Closed 11 years ago
#23171 closed enhancement (fixed)
Add Meetup.com oEmbed support
Reported by: | sennza | Owned by: | |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.5 |
Component: | Embeds | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Given the number of meetups people are doing around the world I think it would be nice to add Meetup.com to the list of oEmbed providers.
http://www.meetup.com/meetup_api/docs/oembed/
Currently there is a minor issue with their oEmbed API as it fails when the Meetup group has a custom domain for the group. I've had to do some dodgy code for our Aussie custom domains to get around that:
https://github.com/BronsonQuick/wpaustralia/blob/master/plugins/wpoz-meetups/wpoz_meetups.php
Seeing their is a new agreement between http://make.wordpress.org/events/ and Meetup.com hopefully one of the Automatticians can let Meetup.com know that their API needs a patch for custom domains ;)
Attachments (3)
Change History (22)
#5
@
12 years ago
I received an email from Meetup.com yesterday regarding custom domains:
We're reaching out to you about a change we've made to how Meetup handles custom domains, which will affect you directly.
We introduced custom domains some time ago and since then, we've incorporated a variety of third parties into the platform for registration, billing and payment collection.
Unfortunately, the way custom domains are currently offered makes it harder for us to ensure a secure browsing experience and incorporate additional third party tools for dues and event fees, so we're changing up how they work going forward.
You can still use a custom domain to point to your Meetup Group, and we will continue to verify if your domain is valid. However, we're turning off link generation to your domain on Meetup pages as of Tuesday, May 7th.
This means the minor issue I mentioned above won't be an issue soon :)
#6
follow-ups:
↓ 7
↓ 8
@
12 years ago
I don't know what the rules are for adding oEmbed support but this seems like a rare case someone will use it. So doesn't a plugin makes more sense. Or is the penalty not that high so we can just add it when a platform supports it?
#7
in reply to:
↑ 6
@
12 years ago
Replying to markoheijnen:
I don't know what the rules are for adding oEmbed support but this seems like a rare case someone will use it. So doesn't a plugin makes more sense. Or is the penalty not that high so we can just add it when a platform supports it?
Related: ticket:21632:3, ticket:21635:7
#8
in reply to:
↑ 6
@
12 years ago
Replying to markoheijnen:
I don't know what the rules are for adding oEmbed support but this seems like a rare case someone will use it. So doesn't a plugin makes more sense.
I had considered doing this in a plugin however I figured that given the number of Meetups people have these days for all kinds of things that it would be great for core. Considering Rdio and Spotify were added the other day I'd like to think the more oEmbeds we can do the better :)
Related: ticket:24242
#11
@
11 years ago
- Keywords commit added
Meetup.com no longer has custom domains, so that's no longer an issue. Based on the criteria for adding oEmbed providers, let's get some traction on this, and either commit or close.
This ticket was mentioned in IRC in #wordpress-dev by rmccue. View the logs.
11 years ago
#13
@
11 years ago
As long as their API seems to work well, I'm game. It may not fit the criteria in terms of super-popular but it's appropriate because of WordPress meetups worldwide, not to mention our official partnership with them.
It would be good to reach out and just touch base with one of their developers, who can say "yeah, use it, it isn't going anywhere!" I'll see if jenmylo can connect me with someone. In the meantime, let's commit this.
It looks like they have an additional meetu.ps URL.
#15
@
11 years ago
#https?://(www\.)?meetu(\.ps|p\.com)/.*#i
handles https and http, www and no www, meetup.com and meetu.ps.
https doesn't work at all, and www doesn't work for meetu.ps. Very little harm in including these, though.
#18
@
11 years ago
Added Meetup.com to the oEmbed providers list in the Codex for 3.9.
#19
@
11 years ago
- Resolution set to fixed
- Status changed from new to closed
https://groups.google.com/d/topic/meetup-api/z0tXN_Uszh8/discussion - reached out to them, all is good.
+1