WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 2 years ago

#23233 reopened enhancement

Radio Button instead of Checkboxes on Comment Moderation option?

Reported by: danielmount Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.5
Component: Comments Keywords: has-patch needs-refresh
Focuses: ui, administration Cc:

Description

Hi! I've been a loyal Wordpress user for years. This is nothing urgent, but something that may improve the user experience.

In Settings > Discussion > Before a comment appears, there are two options: "An administrator must always approve the comment " and "Comment author must have a previously approved comment"

Perhaps I have missed something here, but aren't these options pretty much either/or? If the first box is checked, it's rather irrelevant if the second box is checked, because the first checkbox would override it?

If I'm correct, shouldn't this be changed from a both/and checkbox to an either/or radio button?

Attachments (3)

23233.ux.brainstorming.jpg (70.3 KB) - added by ericlewis 4 years ago.
23233.diff (4.0 KB) - added by ericlewis 4 years ago.
23233.2.diff (6.7 KB) - added by ericlewis 19 months ago.

Download all attachments as: .zip

Change History (28)

#1 @danielmount
5 years ago

  • Cc daniel@… added

#2 in reply to: ↑ description @SergeyBiryukov
5 years ago

  • Component changed from UI to Administration
  • Keywords close added

Replying to danielmount:

If the first box is checked, it's rather irrelevant if the second box is checked, because the first checkbox would override it?

Yes, but it's also possible to uncheck both options. Radio buttons wouldn't allow that.

Related: #16705

#3 @SergeyBiryukov
5 years ago

  • Keywords ui-focus added

#4 @c3mdigital
4 years ago

  • Keywords ui-focus ui-feedback close removed
  • Resolution set to wontfix
  • Status changed from new to closed

Need the 3rd option available of both un checked.

#5 @helen
4 years ago

  • Milestone Awaiting Review deleted

#6 @SergeyBiryukov
4 years ago

  • Keywords ui-focus added

#7 @ericlewis
4 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#8 @ericlewis
4 years ago

I think we can find a way to add in the third option here.

#9 @SergeyBiryukov
4 years ago

  • Milestone set to Awaiting Review

#10 @SergeyBiryukov
4 years ago

  • Severity changed from trivial to normal

#11 @ericlewis
4 years ago

in attachment:23233.ux.brainstorming.jpg I've

  • Removed the separate settings section for "Before the comment appears..." and smushed the options for comment moderation into the "Comment Moderation" settings section. This makes logical sense for the grouping, and allows us to have more open-ended options for these settings since we're not tied to the prefix "Before the comment appears.
  • Using radio buttons for this setting now.
  • Reworded "Before a comment appears Comment must be manually approved" to simply "All comments must be manually approved"
  • Reworded "Before a comment appears Comment author must have a previously approved comment" to "Comments by new commenters must be approved". I think the positive here, rather than the more wordy negation makes sense ("Comments by commenters without a previously approved comment must be approved.")
  • Added an option for "All comments are automatically approved." which is the original point of this ticket.
Last edited 4 years ago by ericlewis (previous) (diff)

#12 follow-up: @danielmount
4 years ago

Eric: I love the changes you propose.

And by the way, it is tremendously exciting for me, as a loyal wordpress user since the 1.5 days, to be able to make a small suggestion that might help improve a detail. :) I've heard for years that participation is what makes Wordpress special, and it's nice to experience it first-hand!

#13 in reply to: ↑ 12 @ericlewis
4 years ago

Replying to danielmount:

I've heard for years that participation is what makes Wordpress special, and it's nice to experience it first-hand!

Opinions from users like yourself is highly appreciated and welcome in the future :)

#14 @danielmount
4 years ago

Eric, thanks! Wordpress is already so close to perfect that I almost never notice anything and think, "perhaps this could be improved"; but should that happen in the future, I'll certainly submit a trac ticket!

#15 @ericlewis
4 years ago

  • Keywords ui-feedback added

#16 @nacin
4 years ago

  • Milestone changed from Awaiting Review to 3.8

This is a great start.

#17 @helen
4 years ago

  • Keywords needs-patch added; ui-feedback removed

Like it a lot - let's see what a patch looks like.

@ericlewis
4 years ago

#18 @ericlewis
4 years ago

attachment:23233.diff implements the recommendations in the previous wireframe.

Changes the text just a bit, so "Comments by new commenters must be approved" becomes "Only comments by new commenters must be approved" for more clarity.

#19 @chrisvanpatten
4 years ago

  • Keywords has-patch added; needs-patch removed

#20 @matt
4 years ago

  • Priority changed from normal to lowest
  • Severity changed from normal to minor

#21 @helen
4 years ago

  • Keywords punt added

Unless somebody with more experience with changing option names and upgrade routines wants to weigh in here, smells like punt.

#22 @ocean90
4 years ago

  • Keywords punt removed
  • Milestone changed from 3.8 to Future Release

#23 @nacin
4 years ago

  • Component changed from Administration to Comments
  • Focuses administration added

This ticket was mentioned in IRC in #wordpress-dev by jenmylo. View the logs.


4 years ago

#25 @chriscct7
2 years ago

  • Keywords needs-refresh added
  • Priority changed from lowest to normal
  • Severity changed from minor to normal

@ericlewis
19 months ago

Note: See TracTickets for help on using tickets.