WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Last modified 15 months ago

#23482 assigned defect (bug)

Fix improper use of comment_exists() in some importers

Reported by: SergeyBiryukov Owned by: maxpagels
Priority: normal Milestone:
Component: Import Version:
Severity: normal Keywords: has-patch close
Cc: Focuses:

Description

Background: #20494

DotClear Importer and TextPattern Importer treat the returned comment post ID as a comment ID:
​http://plugins.trac.wordpress.org/browser/dotclear-importer/trunk/dotclear-importer.php#L416
​http://plugins.trac.wordpress.org/browser/textpattern-importer/trunk/textpattern-importer.php#L429

Attachments (7)

23482.patch​ (1.3 KB ) - added by maxpagels 11 years ago.
Patch for DotClear Importer
23482.2.patch​ (1.2 KB ) - added by maxpagels 11 years ago.
Patch for TextPattern Importer.
23482.3.patch​ (1.4 KB ) - added by maxpagels 11 years ago.
Patch for TextPattern Importer (fixed comments).
23482.4.patch​ (1.5 KB ) - added by maxpagels 11 years ago.
Patch for DotClear Importer (comments fixed).
23482.5.patch​ (1.4 KB ) - added by maxpagels 11 years ago.
Fixed indentation of comments (TextPattern Importer).
23482.6.patch​ (1.5 KB ) - added by maxpagels 11 years ago.
Fixed indentation of comments (Dotclear Importer).
23482.7.patch​ (1.4 KB ) - added by maxpagels 11 years ago.
Fix for comment indentation (Texpattern Importer).

Download all attachments as: .zip

Change History (14)

#1 @chriscct7
11 years ago

  • Keywords needs-patch good-first-bug added

@maxpagels
11 years ago

Patch for DotClear Importer

@maxpagels
11 years ago

Patch for TextPattern Importer.

#2 @maxpagels
11 years ago

Regarding the above patches, a more elegant solution may well exist, but this should work.

@maxpagels
11 years ago

Patch for TextPattern Importer (fixed comments).

@maxpagels
11 years ago

Patch for DotClear Importer (comments fixed).

#3 @obenland
11 years ago

  • Owner set to maxpagels
  • Status new → assigned

#4 @maxpagels
11 years ago

  • Keywords has-patch needs-testing added; needs-patch good-first-bug removed

Will update the patches with proper indenting (sorry, didn't catch it the first time.)

Last edited 11 years ago by maxpagels (previous) (diff)

#5 @maxpagels
11 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

@maxpagels
11 years ago

Fixed indentation of comments (TextPattern Importer).

@maxpagels
11 years ago

Fixed indentation of comments (Dotclear Importer).

@maxpagels
11 years ago

Fix for comment indentation (Texpattern Importer).

#6 @maxpagels
11 years ago

  • Keywords has-patch needs-testing added; needs-patch removed
Last edited 11 years ago by maxpagels (previous) (diff)

#7 @SirLouen
15 months ago

  • Keywords close added; needs-testing removed

Similar to the Livejournal importer ticket, I think its time to close this, wontfix (or report this in their respective plugin support ticketing, ​here and ​here)

Note: See TracTickets for help on using tickets.