Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#23702 closed enhancement (fixed)

Twenty Thirteen: use new HTML5 comment form argument

Reported by: lancewillett's profile lancewillett Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Once #15080 changes are in core, update Twenty Thirteen to include the new html5 argument in comment_form(). Then adjust CSS selectors if needed.

Attachments (2)

23702.diff (1.2 KB) - added by obenland 12 years ago.
23702.1.diff (1.9 KB) - added by lancewillett 12 years ago.
Simplify comment form label selectors

Download all attachments as: .zip

Change History (7)

@obenland
12 years ago

#1 follow-up: @obenland
12 years ago

  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

Patch is based on 15080.6.diff​

Last edited 12 years ago by lancewillett (previous) (diff)

#2 in reply to: ↑ 1 @lancewillett
12 years ago

Replying to obenland:

Patch is based on 15080.6.diff​

http://core.trac.wordpress.org/attachment/ticket/15080/15080.6.diff

Working well in testing. So happy to see this improved markup!

#3 follow-up: @lancewillett
12 years ago

@obenland How do you feel about changing:

#commentform label[for="author"],
#commentform label[for="email"],
#commentform label[for="url"],
#commentform label[for="comment"] {
	float: left;
	padding: 5px 0;
	width: 100px;
}

to just:

#commentform label {
	float: left;
	padding: 5px 0;
	width: 100px;
}

#4 in reply to: ↑ 3 @obenland
12 years ago

Replying to lancewillett:

@obenland How do you feel about changing [labels]

+1

@lancewillett
12 years ago

Simplify comment form label selectors

#5 @lancewillett
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [23690] Twenty Thirteen: use new HTML5 comment form argument, and adjust CSS selectors a bit. Closes #23702, see #15080.

Note: See TracTickets for help on using tickets.