WordPress.org

Make WordPress Core

#23702 closed enhancement (fixed)

Twenty Thirteen: use new HTML5 comment form argument

Reported by: lancewillett Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Once #15080 changes are in core, update Twenty Thirteen to include the new html5 argument in comment_form(). Then adjust CSS selectors if needed.

Attachments (2)

23702.diff (1.2 KB) - added by obenland 13 months ago.
23702.1.diff (1.9 KB) - added by lancewillett 13 months ago.
Simplify comment form label selectors

Download all attachments as: .zip

Change History (7)

obenland13 months ago

comment:1 follow-up: obenland13 months ago

  • Keywords has-patch added; needs-patch removed
  • Version set to trunk

Patch is based on 15080.6.diff​

Last edited 13 months ago by lancewillett (previous) (diff)

comment:2 in reply to: ↑ 1 lancewillett13 months ago

Replying to obenland:

Patch is based on 15080.6.diff​

http://core.trac.wordpress.org/attachment/ticket/15080/15080.6.diff

Working well in testing. So happy to see this improved markup!

comment:3 follow-up: lancewillett13 months ago

@obenland How do you feel about changing:

#commentform label[for="author"],
#commentform label[for="email"],
#commentform label[for="url"],
#commentform label[for="comment"] {
	float: left;
	padding: 5px 0;
	width: 100px;
}

to just:

#commentform label {
	float: left;
	padding: 5px 0;
	width: 100px;
}

comment:4 in reply to: ↑ 3 obenland13 months ago

Replying to lancewillett:

@obenland How do you feel about changing [labels]

+1

lancewillett13 months ago

Simplify comment form label selectors

comment:5 lancewillett13 months ago

  • Resolution set to fixed
  • Status changed from new to closed

In [23690] Twenty Thirteen: use new HTML5 comment form argument, and adjust CSS selectors a bit. Closes #23702, see #15080.

Note: See TracTickets for help on using tickets.