Require relative to working directory, not file

[hakre]

Some requires are done relative to the current working directory of the script albeit those are meant to be relative to the file itself.

This should also prevent to trigger a PHP include path search.

[nacin]

Looking good. A few points:

• dirname( dirname( __FILE__ ) ) . '/foo' is preferred to dirname( __FILE__ ) . '/../'.
• Once the bootstrap is available, we should use ABSPATH . 'wp-admin/admin-footer.php;' (et al), ABSPATH . WPINC, etc.

[hakre]

Fine. The first point of your comment - double / triple / quadrupel dirname preference - is addressed with the latest attachment.

For the second point I need more pointers by you, e.g. 2-3 examples so I do see the issue. It's perhaps not worth the work for this issue and could be put into another one if you think this is worth to change.

[ocean90]

Duplicate of #17092.

[ocean90]

hakre, can you add your patches to #17092 please?

We should also take another look at the statement from sivel, ticket:17092:3.

[hakre]

Replying to ocean90:

hakre, can you add your patches to #17092 please?

Yes.

We should also take another look at the statement from sivel, ticket:17092:3.

You mean the micro-optimization bs?

[hakre]

Replying to nacin:

Looking good. A few points:

• dirname( dirname( __FILE__ ) ) . '/foo' is preferred to dirname( __FILE__ ) . '/../'.
• Once the bootstrap is available, we should use ABSPATH . 'wp-admin/admin-footer.php;' (et al), ABSPATH . WPINC, etc.

The patch is now on ticket #17092 ​http://core.trac.wordpress.org/attachment/ticket/17092/17092.001.patch

ABSPATH is now used as applicable.

I'm through with it, please give it some traction it's a hell of a work.