WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#25569 closed enhancement (fixed)

Remove the Custom Background Screen in Favor of the Customizer

Reported by: celloexpressions Owned by: celloexpressions
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: Cc:

Description

We can't really expect theme developers to use the customizer instead of theme options pages if we continue to rely on separate pages for core customization features. We have 90% of the custom background screen in the customizer already; once #21483 is done (media library integration), there's no reason to have all of this duplicate functionality. The customizer provides a much better experience anyway, with the live preview.

Added benefits: removing an item from the admin menu's appearance section will probably increase traffic to the customizer from users poking around to see what they can do/look for options. And we'll have even more functionality there too.

There aren't any actions in this screen (and I believe the filters are/will become irrelevant), so we don't need to worry about back-compat for that. Perhaps there are ways that plugins could break, but we can probably get away with removing most, if not all, of wp-admin/custom-background.php.

Attachments (4)

25569-25571.diff (3.2 KB) - added by celloexpressions 5 years ago.
Link header and background to Customizer in the admin menu when it's supported, only show them in the admin bar when the Customizer isn't supported.
25569-25571.2.diff (3.4 KB) - added by celloexpressions 5 years ago.
With deep-linking.
25569-25571.3.diff (4.9 KB) - added by westonruter 5 years ago.
https://github.com/xwpco/wordpress-develop/pull/50
25569-25571.4.diff (5.0 KB) - added by ocean90 5 years ago.

Download all attachments as: .zip

Change History (27)

#1 @dreamwhisper
6 years ago

  • Cc dreamwhisper added

#4 @lancewillett
6 years ago

  • Cc lancewillett added

#5 @goto10
6 years ago

  • Cc dromsey@… added

#6 @shelob9
6 years ago

  • Cc JPollock412@… added

#7 @shelob9
6 years ago

Related: #26386

#8 @celloexpressions
6 years ago

This could potentially happen for headers soon, so once backgrounds have recieved another iteration in the customizer, we can follow the same approach as #25571, hiding the page when the customizer is supported.

#9 @celloexpressions
5 years ago

  • Milestone changed from Awaiting Review to 4.1

Per this week's dev chat, we'd like to do this in 4.1, especially with Twenty Fifteen's emphasis on this feature and the reworking of background images in the Customizer in #21483.

Three options:

  • Hide the link for users who can access the Customizer.
  • Show the existing link for users who can't access the Customizer, and a deep-link into the Customizer for users who can access it. Requires #28650.
  • Remove the link from the admin menu entirely, potentially removing related code/files.

We also need to decide whether we want to bother continued maintenance of these screens and whether we can close the numerous tickets related to them.

Last edited 5 years ago by celloexpressions (previous) (diff)

#10 @wonderboymusic
5 years ago

  • Milestone changed from 4.1 to Future Release

I am moving this into the backlog until there is a patch - there are a lot of Customizer tickets. If a patch materializes, great.

#11 @celloexpressions
5 years ago

  • Milestone changed from Future Release to 4.1
  • Owner set to celloexpressions
  • Status changed from new to assigned

This ticket doesn't really hinge on a patch (which will be trivial) - it's more a tracking ticket for making sure that this happens along with the work-in-progress changes here and the emphasis that Twenty Fifteen is placing on this feature. First step is to make some decisions about how we should handle this (redirecting, removing links from admin menu entirely, level of ongoing support for the existing pages, which would only be accessible in no-js and a couple other situations), which needs to happen at a dev chat in the near future (not a broad enough base at Customizer meetings for this particular issue).

#12 follow-up: @celloexpressions
5 years ago

I won't be able to make it to the dev chat next week, but if someone could add this to agenda that would be great. Need a decision on the 3 options for how to kill this and the header (#25571) admin pages. Then we can make a patch.

#13 in reply to: ↑ 12 @DrewAPicture
5 years ago

Replying to celloexpressions:

I won't be able to make it to the dev chat next week, but if someone could add this to agenda that would be great. Need a decision on the 3 options for how to kill this and the header (#25571) admin pages. Then we can make a patch.

Noted.

@celloexpressions
5 years ago

Link header and background to Customizer in the admin menu when it's supported, only show them in the admin bar when the Customizer isn't supported.

#14 @celloexpressions
5 years ago

  • Keywords has-patch added

It ended up making more since to do one patch for both this and #25571 to avoid conflicting patches, but we'll want to keep this one open after the initial commit for tracking since we need to add media library access to the Customizer for feature-parity, or revert this part. #21483 is waiting for commit or dev feedback from #29723 and #29572 before it can proceed.

25569-25571.diff should be committable now, then we can add the deep-linking once that's ready. But now would be a great time for any suggestions on alternate implementations. I went with the deep-linking approach, as that's what the consensus was during the Customizer meetings and there don't seem to be other strong opinions one way or another. Unfortunately, the best way to implement hiding the existing links when the Customizer is supported is with CSS, but I think it's reasonably clean, especially relative to the other options.

This ticket was mentioned in IRC in #wordpress-dev by celloexpressions. View the logs.


5 years ago

@celloexpressions
5 years ago

With deep-linking.

#16 @westonruter
5 years ago

See description of changes in 25569-25571.3.diff in 25571#comment:12, along with an important gotcha I just realized.

This ticket was mentioned in Slack in #core by westonruter. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by ocean90. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by celloexpressions. View the logs.


5 years ago

#20 @ocean90
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 30459:

Customizer: Use deep-links for Backgrounds, Headers, and Widgets.

Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.

#21 @ocean90
5 years ago

In 30657:

Make notices added in [30459] less ugly.

see #25569, #25571, [30505].

#23 @ocean90
5 years ago

In 30793:

Themes: Use Customizer deep-links inside the theme modal.

props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.

Note: See TracTickets for help on using tickets.