WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#26468 closed enhancement (fixed)

Add additional color schemes back into core

Reported by: melchoyce Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

Our current four color schemes are all pretty masculine and kind of similar. Let's add Seaweed and Ectoplasm into core. They're both bright, colorful, and pretty gender neutral.

Attachments (5)

26468.diff (2.8 KB) - added by ryelle 5 years ago.
26468.2.diff (1.8 KB) - added by ryelle 5 years ago.
26468.3.diff (3.6 KB) - added by ryelle 5 years ago.
26468.4.diff (3.6 KB) - added by ryelle 5 years ago.
26468.5.diff (3.7 KB) - added by ryelle 5 years ago.

Download all attachments as: .zip

Change History (17)

@ryelle
5 years ago

#1 @ryelle
5 years ago

26468.diff contains ectoplasm & seaweed (and sets up for another color scheme variable, $action-color)

@ryelle
5 years ago

#2 @ryelle
5 years ago

removed the $action-color sass variable.

#3 @nacin
5 years ago

  • Milestone changed from Awaiting Review to 3.8

#4 @nacin
5 years ago

  • Keywords has-patch commit added

@ryelle
5 years ago

@ryelle
5 years ago

#5 @ryelle
5 years ago

26468.4.diff adds 4 schemes: Cyano, Ocean, Coffee, and Ectoplasm, and switches the scheme picker to 4 per row.

#6 @helen
5 years ago

No bright or warm colors? Has a sad.

@ryelle
5 years ago

#7 @ryelle
5 years ago

color schemes revised: now includes coffee, ocean, ectoplasm and sunrise.

#8 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26773:

Add four more color schemes to round out our collection at eight.

The new schemes are Ectoplasm, Coffee, Ocean, Sunrise. For those following along, the first three were at one point named Ghostbusters, Pixel, and Cape Cod.

See [26137] for the original color schemes.

props ryelle, melchoyce, drw158, littlethingsstudio.
fixes #26468. see #25858, #22862.

#9 @nacin
5 years ago

In 26776:

Core updates for the new color schemes.

  • Update about page, there's now 8.
  • Display them four wide, not three, and ensure adequate spacing.
  • Use a dedicated nonce.
  • Push Light to the front in addition to Default.
  • Use user-profile.js on about.php. A few extra things are initialized but they are harmless.

see #26468, #26387.

#10 @helen
5 years ago

In 26804:

Remove duplicated lines in Ectoplasm's .scss file. see #26468.

#11 @helen
5 years ago

[26776] causes notices when light isn't a registered color scheme (e.g. running out of src) but you do have more than one. Probably does the same if default/fresh isn't registered.

Notice: Trying to get property of non-object in /srv/www/wp-core/develop/src/wp-admin/includes/misc.php on line 592

Notice: Trying to get property of non-object in /srv/www/wp-core/develop/src/wp-admin/includes/misc.php on line 597

Warning: Invalid argument supplied for foreach() in /srv/www/wp-core/develop/src/wp-admin/includes/misc.php on line 597

#12 @nacin
5 years ago

In 26814:

Avoid notices when default and light are not registered color schemes. see #26468.

Note: See TracTickets for help on using tickets.