Opened 11 years ago
Closed 8 years ago
#26580 closed enhancement (fixed)
Add filters to WP_MS_Sites_List_Table::prepare_items()
Reported by: | csixty4 | Owned by: | flixos90 |
---|---|---|---|
Milestone: | 4.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | good-first-bug has-patch |
Focuses: | multisite | Cc: |
Description
In WP_MS_Sites_List_Table::prepare_items(), it would be helpful to be able to filter $like_s
before it gets integrated into the query (we needed to force a like %keyword%
query).
It might also be handy to filter the WHERE and ORDER BY clauses.
The query
filter can be used to alter the SQL after it's generated, but that's just asking for trouble.
Attachments (2)
Change History (15)
#3
@
11 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
#25338 is related in the sense that there's this general trend of wanting to be able to easily filter prepare_items()
. I think it would be interesting to see a patch (that would also solve pagination, total items, etc.)
#4
@
10 years ago
Hi.
In the attached file I imported a simple filter "wpmu_blogs_orderby' in prepare_items() function. This way at least a custom column made be a plugin can be sortable.
Example usage:
Sort a custom column created from a plugin which shows the "deleted" field of wp_blogs
add_filter( 'wpmu_blogs_orderby' , 'mycustom_column_orderby' ) ; function mycustom_column_orderby( $order_by ) { if ( $order_by == 'deleted' ) { $query = 'ORDER BY deleted ' ; return $query ; } else { return null ; } }
What do you think about this solution?
#5
follow-up:
↓ 6
@
9 years ago
This would also be useful to have plugins give the ability to add filters to the sites list. Like, only show deleted/active sites.
#6
in reply to:
↑ 5
@
9 years ago
I think that's slightly different than the title of this ticket, although it is definitely related. I created #32956 to add the frontend requirements for what you need :)
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
8 years ago
#9
@
8 years ago
- Keywords good-first-bug added
After [37736], WP_MS_Sites_List_Table
is now in a better position for a ms_sites_list_table_query_args
filter. Marking this as a good first bug.
This ticket was mentioned in Slack in #core by ocean90. View the logs.
8 years ago
#12
@
8 years ago
- Keywords has-patch added; needs-patch removed
26580.diff adds the filter for the query arguments.
Related: #25360