Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#27263 closed defect (bug) (fixed)

Z-Index is wrong when a post is both locked and the auth check fails

Reported by: lkwdwrd's profile lkwdwrd Owned by: helen's profile helen
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords: has-patch
Focuses: ui Cc:

Description (last modified by DrewAPicture)

When on a post that is locked and the auth check fails, the post lock box is currently sitting above the reauthorization box. They need to be switched so that the reauthorization action has the priority.

http://f.cl.ly/items/3r2g3p1u0n2B3I1t0P3v/modals.png

Attachments (3)

27263.diff (617 bytes) - added by lkwdwrd 10 years ago.
27263.2.diff (599 bytes) - added by kirasong 10 years ago.
Refreshed after [27532].
27263.3.diff (722 bytes) - added by lkwdwrd 10 years ago.
Adds comments to the z-index values

Download all attachments as: .zip

Change History (9)

@lkwdwrd
10 years ago

#1 @DrewAPicture
10 years ago

  • Component changed from Appearance to Administration
  • Description modified (diff)
  • Focuses administration removed
  • Keywords has-patch added

#2 @DrewAPicture
10 years ago

  • Milestone changed from Awaiting Review to 3.9

Confirmed. 27263.diff fixes it for me:

http://f.cl.ly/items/0Y171r2B3n323W0V2v1f/Screen%20Shot%202014-03-03%20at%2011.12.21%20AM.png

@kirasong
10 years ago

Refreshed after [27532].

#3 @kirasong
10 years ago

27263.2.diff looks to do the trick.

Refreshed after [27532] changed opacity.

#4 @kirasong
10 years ago

@lkwdwrd, is there are reason you decided to increment to z-index: 1000010/z-index: 1000011 rather than swap the previous z-indexes?

@lkwdwrd
10 years ago

Adds comments to the z-index values

#5 @lkwdwrd
10 years ago

Looking at https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/edit.css#L458, and it's corresponding background, both dialogues are attempting to use a base of 1000000.

Switching to 1000010 and 1000010 bumps it above the notification dialogue while not adding a crazy amount of z-index to the mix.

I've added some comments in 27263.3.diff noting what elements the z-index puts it on top of.

#6 @helen
10 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 27752:

Post lock dialog should not appear above the auth check login prompt.

props lkwdwrd. fixes #27263.

Note: See TracTickets for help on using tickets.