WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27400 closed defect (bug) (fixed)

Widget Customizer: Add widget reordering icons to Dashicons

Reported by: westonruter Owned by: melchoyce
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.9
Component: Widgets Keywords: needs-patch
Focuses: ui Cc:

Description

The Widget Customizer plugin used Genericons for the keyboard-accessible widget reordering buttons:

https://f.cloud.github.com/assets/134745/1756800/d153b620-6677-11e3-8473-8e70fe445784.png

As noted in the plugin's CSS, these need to be moved into Dashicons: https://github.com/x-team/wp-widget-customizer/blob/59836a7c6fa672e864286403653a094773450b2f/widget-customizer.css#L1-L25

The CSS selectors using these font icons are: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/customize-widgets.css?rev=27419#L84

.customize-control-widget_form.expanded a.widget-action:after {
	content: "\f142";
}

.customize-control-widget_form.wide-widget-control a.widget-action:after {
	content: "\f139";
}

.customize-control-widget_form.wide-widget-control.expanded a.widget-action:after {
	content: "\f141";
}

Originally introduced by @michael-arestad in https://github.com/x-team/wp-widget-customizer/pull/75

Attachments (4)

27400.diff (1.1 KB) - added by melchoyce 6 years ago.
27400.2.diff (1.1 KB) - added by melchoyce 6 years ago.
27400.3.diff (1.8 KB) - added by melchoyce 6 years ago.
27400.4.diff (656 bytes) - added by Michael Arestad 6 years ago.
Change positioning of reorder icons

Download all attachments as: .zip

Change History (16)

#1 @melchoyce
6 years ago

Let's use .dashicons-arrow-up-alt2 and .dashicons-arrow-down-alt2 for the arrows. I've updated them to look a little nicer. I've additionally made a new "move" icon. I'll be posting both the new arrow icons and the move icon to #26936 so empireoflight can add them to the dashicons font file. Once the icons are in, we can patch in this ticket.

#2 @ocean90
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.9

#3 @ocean90
6 years ago

#27478 was marked as a duplicate.

#4 @ocean90
6 years ago

#27475 was marked as a duplicate.

#5 @nacin
6 years ago

  • Owner set to melchoyce
  • Status changed from new to assigned

#6 @ocean90
6 years ago

Icons are in, see [27989]. melchoyce is preparing a patch.

@melchoyce
6 years ago

#7 @melchoyce
6 years ago

I tried fixing the icons in 27400.diff but for some reason, now the icons aren't displaying at all. Can someone take a quick look and see if they can figure out what I'm doing wrong?

@melchoyce
6 years ago

#8 @melchoyce
6 years ago

27400.2.diff should do the trick, but I wouldn't mind another look from westonruter or michael-arestad. Thanks ocean90 for the help.

@melchoyce
6 years ago

#9 @melchoyce
6 years ago

27400.3.diff fixes the font size (16px -> 20px) and adds in some browser-specific font smoothing.

#10 @ocean90
6 years ago

In 28005:

Widget Customizer: Update icons to new Dashicons.

props melchoyce.
see #27400.

@Michael Arestad
6 years ago

Change positioning of reorder icons

#11 @Michael Arestad
6 years ago

Changed from using top position to line-height. Then the vertical media query kicks in properly.

See 27400.4.diff

#12 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 28013:

Widget Customizer: Update icons to new Dashicons, part 2.

props Michael Arestad.
fixes #27400.

Note: See TracTickets for help on using tickets.