Opened 11 years ago
Closed 11 years ago
#27400 closed defect (bug) (fixed)
Widget Customizer: Add widget reordering icons to Dashicons
Reported by: | westonruter | Owned by: | melchoyce |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | Widgets | Keywords: | needs-patch |
Focuses: | ui | Cc: |
Description
The Widget Customizer plugin used Genericons for the keyboard-accessible widget reordering buttons:
As noted in the plugin's CSS, these need to be moved into Dashicons: https://github.com/x-team/wp-widget-customizer/blob/59836a7c6fa672e864286403653a094773450b2f/widget-customizer.css#L1-L25
The CSS selectors using these font icons are: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/css/customize-widgets.css?rev=27419#L84
.customize-control-widget_form.expanded a.widget-action:after { content: "\f142"; } .customize-control-widget_form.wide-widget-control a.widget-action:after { content: "\f139"; } .customize-control-widget_form.wide-widget-control.expanded a.widget-action:after { content: "\f141"; }
Originally introduced by @michael-arestad in https://github.com/x-team/wp-widget-customizer/pull/75
Attachments (4)
Change History (16)
#7
@
11 years ago
I tried fixing the icons in 27400.diff but for some reason, now the icons aren't displaying at all. Can someone take a quick look and see if they can figure out what I'm doing wrong?
#8
@
11 years ago
27400.2.diff should do the trick, but I wouldn't mind another look from westonruter or michael-arestad. Thanks ocean90 for the help.
#9
@
11 years ago
27400.3.diff fixes the font size (16px -> 20px) and adds in some browser-specific font smoothing.
#11
@
11 years ago
Changed from using top position to line-height. Then the vertical media query kicks in properly.
See 27400.4.diff
Let's use .dashicons-arrow-up-alt2 and .dashicons-arrow-down-alt2 for the arrows. I've updated them to look a little nicer. I've additionally made a new "move" icon. I'll be posting both the new arrow icons and the move icon to #26936 so empireoflight can add them to the dashicons font file. Once the icons are in, we can patch in this ticket.