WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#27890 closed defect (bug) (fixed)

Customizer: "Add new image" button reference

Reported by: SergeyBiryukov Owned by: jjeaton
Milestone: 4.0 Priority: low
Severity: trivial Version: 3.9
Component: Customize Keywords: good-first-bug has-patch commit fixed-major i18n-change
Focuses: Cc:

Description

The Header Image section intro says:

While you can crop images to your liking after clicking Add new...

tags/3.9/src/wp-includes/class-wp-customize-control.php#L855

However, the button is called "Add new image" since [27947].

Attachments (1)

27890.diff (1.5 KB) - added by jjeaton 6 years ago.

Download all attachments as: .zip

Change History (10)

@jjeaton
6 years ago

#1 @jjeaton
6 years ago

  • Keywords has-patch added; needs-patch removed

Patch to change button's name in header image intro text.

#2 @nacin
6 years ago

  • Milestone changed from Awaiting Review to 3.9.1

Moving to 3.9.1 for tracking purposes; we may not do a string change until 4.0.

#3 @nacin
6 years ago

In 28170:

Customizer: Correct reference to the 'Add new image' button.

props jjeaton.
see #27890, for trunk.

#4 @nacin
6 years ago

  • Keywords commit fixed-major added
  • Owner set to jjeaton
  • Status changed from new to assigned

Nice work, jjeaton!

#5 @nacin
6 years ago

  • Keywords i18n-change added

#6 @nacin
6 years ago

  • Milestone changed from 3.9.1 to 3.9.2

Holding onto this until 3.9.2 or later.

#7 @ocean90
6 years ago

#28115 was marked as a duplicate.

#8 @dimadin
6 years ago

My trunk didn't get [28170] for some reason so I opened #28115. I suggest that we still change only in one string for reasons mentioned in #28115 and revert changes from [28170].

#9 @helen
6 years ago

  • Milestone changed from 3.9.2 to 4.0
  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.