Make WordPress Core

Opened 10 years ago

Last modified 4 weeks ago

#29838 assigned defect (bug)

Post editing area: keyboard accessibility, tab order and focus

Reported by: afercia's profile afercia Owned by: rcreators's profile rcreators
Milestone: 6.7 Priority: normal
Severity: normal Version: 4.0
Component: Editor Keywords: has-patch
Focuses: ui, accessibility Cc:

Description

This ticket aims to focus on a specific area of the UI, let's call it "Post editing area", the one that starts with the "Title" field and ends with the editor area, both in "Visual" and "Text" mode.

Related: #27553 while researching we noticed:

joedolson: outstanding issues surrounding tab order, but this are long-standing and not relevant to this specific patch and issue; that needs to be raised separately.

There's room for accessibility improvements here, especially when it comes to tab order and focus management. To fully understand what's going on you should stop for a while being a "nervous clicker" :) and:

  • apply the patch from #27553
  • unplug your mouse and disable your trackpad :)
  • use just your keyboard
  • tab around, both forwards and backwards

It would be great to test also switching off your display and using a screen reader, I would recommend Firefox and NVDA.

Two main issues:

Focus.
When you're in the "Title" field and then you tab forwards, focus is moved directly inside the editor area skipping all what's in between.
While this *may* be useful for sighted keyboard users (they save a few key presses, say 1 second?), it's a very critical experience for screen reader users: when they tab forwards, they get that right after the title there's the editor. But when they tab backwards, they get many more elements that "weren't there before". more details on 27553 comments.

Tab order.
The "tabbing experience" in Visual and Text mode should match as much as possible. Ideally, there should be a better logical sequence in the markup. When editing the title, the next logical step is editing the content, all the other controls (Add Media button, additional buttons provided by plugins and themes, etc.) should not be placed between the Title and the editor. The CEUX project proposed something similar at some point.

There is ongoing research and development on the editing experience, see for example Editor Focus/DFW in #29806 and the idea to review relevant parts of the UI, see explore moving the Publish | Save | Preview buttons out of the metabox, etc. so it would be a great opportunity to explore this ticket too.

Attachments (3)

29838.diff (5.9 KB) - added by afercia 2 months ago.
29838.patch (5.1 KB) - added by rcreators 2 months ago.
@afercia 's patch updated to run for new wordpress. So can use to check for starting point and direction for next development.
29838.2.diff (8.5 KB) - added by joedolson 6 weeks ago.
Fixes problem with previous patch formatting & continues work

Download all attachments as: .zip

Change History (46)

#1 @joedolson
10 years ago

This is definitely an important issue; regardless of any screen reader questions, the experience for a keyboard-dependent user in the editor is simply confusing; it's extremely hard to predict where you're going to go next or figure out how to get to certain controls via the keyboard.

#2 @trishasalas
10 years ago

This ticket is a lot to absorb! I'm going to read through all of the associated tickets and test this myself so that I have a better understanding of the behavior the ticket is describing. I'll reply back here afterwards. I'd love to help work some of these issues out :)

This ticket was mentioned in IRC in #wordpress-ui by _Redd. View the logs.


10 years ago

This ticket was mentioned in IRC in #wordpress-ui by _Redd. View the logs.


10 years ago

This ticket was mentioned in IRC in #wordpress-ui by _Redd. View the logs.


10 years ago

#6 @afercia
10 years ago

Just to keep track of the changes related to the tab order in this area, now the WP editor "toggle tabs" are focusable, see changeset 30002

#7 @afercia
10 years ago

Interesting also for the user experience on desktop, see the video posted by Mark Jaquith. I couldn't agree more, especially about his comment on the section on the top, in the last 30 seconds.
Post editing experience on iPhone 6
https://make.wordpress.org/flow/2014/11/11/post-editing-experience-on-iphone-6/

This ticket was mentioned in Slack in #design by afercia. View the logs.


9 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 years ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


9 years ago

#12 @afercia
9 years ago

New related post by Ryan Boren:
The location of Add Media on phones

Last edited 8 years ago by afercia (previous) (diff)

#14 @afercia
9 years ago

Related: #33895

This ticket was mentioned in Slack in #core by afercia. View the logs.


9 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


9 years ago

#17 @afercia
8 years ago

#36659 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


8 years ago

#19 @afercia
8 years ago

  • Milestone changed from Awaiting Review to Future Release

Discussed this during today's accessibility bug scrub and it is definitely something we'd like to discuss at WCEU, maybe also a good candidate for a feature project.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 years ago

#22 @afercia
8 years ago

Related: #29923

#23 @afercia
7 years ago

For similar issues related to the new Editor project (Gutenberg), see https://github.com/WordPress/gutenberg/issues/467

This ticket was mentioned in Slack in #design by afercia. View the logs.


7 years ago

#25 @afercia
7 years ago

#40691 was marked as a duplicate.

This ticket was mentioned in Slack in #accessibility by nrqsnchz. View the logs.


4 years ago

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


8 months ago

#28 @joedolson
8 months ago

  • Keywords needs-patch added
  • Milestone changed from Future Release to 6.5
  • Owner set to joedolson
  • Status changed from new to accepted

#29 @joedolson
8 months ago

Per conversation with @alexstine in an accessibility bug scrub, he'd like to see this happen. He comments (with reference to the classic editor):"I think we should push for the improvement. To date, it's how blind people still use self-hosted WordPress."

Practically, if this is the primary tool for a group of people, we should still explore beneficial changes.

#30 @afercia
8 months ago

Now that this is milestoned for 6.5, I'd like to give it a try.

#31 @swissspidy
5 months ago

  • Milestone changed from 6.5 to 6.6

Given the lack of activity & patch I am punting this to 6.6 for now.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


2 months ago

#33 @joedolson
2 months ago

  • Owner changed from joedolson to rcreators
  • Status changed from accepted to assigned

@rcreators has offered to dive in and work on this, so I'm assigning it to him.

@afercia
2 months ago

#34 @afercia
2 months ago

A while ago I did start some exploration but didn't have time to move on.

29838.diff is to illustrate what I was exploring. Don't trust the code in the patch, don't commit it :) It's purely for exploration and maybe a good starting point.

Most notably, the first things I explored are:

  • Remove the code meant to skip native tab stops from the post title to the post content.
  • Add a new function in tinymce/plugins/wordpress/plugin.js to make Shift + Tab move focus from the post content to the TinyMCE toolbar.
  • Remove tabfocus_elements from the TinyMCE config. See the TinyMCE documentation for more details on what this config param is about.

I was also experimenting with selection and scroll position but that was very experimental.

#35 @rcreators
2 months ago

@afercia Not sure why, but not able to apply this patch. Giving me error at line no 51. Looking at that line looks fine to me. Just have

Index: src/js/_enqueues/wp/editor/base.js

Looks good. Stil getting errors. Can anyone try to apply this on the latest fork/branch?

#36 @afercia
2 months ago

@rcreators sorry I was not clear. I was working on that patch a few months ago. It may not apply cleanly any longer. I uploaded 29838.diff to this ticket only to give some suggestions on where to start. I wouldn't recommend to try to apply the patch. Rather, I'd suggest to have a look at the code and get some inspiration from there.

@rcreators
2 months ago

@afercia 's patch updated to run for new wordpress. So can use to check for starting point and direction for next development.

@joedolson
6 weeks ago

Fixes problem with previous patch formatting & continues work

#37 @joedolson
6 weeks ago

Updated patch fixes a problem with the patch formatting in 29838.patch, adds missing focus state on selected editor toggle, adds aria-pressed attributes to report selected editor toggle, and starts adding some handling to prevent the focus change that sets the cursor position in the editor if a user switches the editor using the keyboard. (Not fully functional yet.)

#38 @shailu25
6 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

#39 @joedolson
6 weeks ago

  • Keywords needs-patch added; has-patch needs-testing removed

Restoring workflow keywords. @shailu25 Just a note; if the comment specifically says that the patch isn't fully functional yet, it's better to leave it as "needs patch", since the patch still needs to be finished.

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.


6 weeks ago

#41 @sabernhardt
6 weeks ago

  • Milestone changed from 6.6 to 6.7

The patch still needs work, so I'm moving this to milestone 6.7. Please feel free to move it back to 6.6 if there is a ready-to-commit patch before the end of the beta phase.

Last edited 6 weeks ago by sabernhardt (previous) (diff)

#42 @Benjamin_Zekavica
5 weeks ago

Accessibility Testing on: 6.6-beta2-58392-src

@joedolson The last version works fine for the Keyboard. I can switch the focus of all elements by using the keyboard. Currently the cursor inside the Classic Text Editor jumps inside the text Editor not to the focus Text button. It needs to change it as well.

For example: If you choose an image, than the cursor jumps after the image HTML Tag and not to the text Button.

Last edited 5 weeks ago by Benjamin_Zekavica (previous) (diff)

This ticket was mentioned in PR #6877 on WordPress/wordpress-develop by @Benjamin_Zekavica.


4 weeks ago
#43

  • Keywords has-patch added; needs-patch removed
Note: See TracTickets for help on using tickets.