WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#29984 closed defect (bug) (fixed)

Twenty Fifteen: editor-style and Noto Fonts

Reported by: Manoz69 Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Little fix for Noto Serif font.

If "Noto Serif" is used in font-family, then serif should be used instead of sans-serif.

Attachments (1)

29984.patch (1.0 KB) - added by Manoz69 7 years ago.

Download all attachments as: .zip

Change History (11)

@Manoz69
7 years ago

#1 @iamtakashi
7 years ago

  • Type changed from enhancement to defect (bug)

#2 @iandstewart
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.1

#3 @iandstewart
7 years ago

@Manoz69 this is your first bug report! And there's a patch? Awesome. Thanks! As a reminder for the many bug reports and patches to come, make your diffs not from /src but from your install.

#4 @iandstewart
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with r29918

#5 follow-up: @Manoz69
7 years ago

I have a secret: I did some Theme reviews :) About the .patch I read the docs. I have a question: is there a difference between .diff and .patch files for you?

And thx for the tips :)

Last edited 7 years ago by Manoz69 (previous) (diff)

#6 in reply to: ↑ 5 @iandstewart
7 years ago

Replying to Manoz69:

I have a secret: I did some Theme reviews :) About the .patch I read the docs. I have a question: is there a difference between .diff and .patch files for you?

And thx for the tips :)

No diff between patch 'n diff.

#7 follow-ups: @iseulde
7 years ago

As a reminder for the many bug reports and patches to come, make your diffs not from /src but from your install.

Doesn't matter I think? I always make my patches form src.

#8 in reply to: ↑ 7 @Manoz69
7 years ago

Replying to avryl:

As a reminder for the many bug reports and patches to come, make your diffs not from /src but from your install.

Doesn't matter I think? I always make my patches form src.

A way to watch if the reporter has really tried his fix?

#9 in reply to: ↑ 7 @afercia
7 years ago

Replying to avryl:

Doesn't matter I think? I always make my patches form src.

That's the reason why they don't work for me :) Please don't do that :)
People on different platforms use different SVN tools, for example on Windows TortoiseSVN warns me about a mismatched "path" with your patches. Also refer to the Core Handbook

...ensure that you are in the root directory created by your SVN checkout...

#10 in reply to: ↑ 7 @SergeyBiryukov
7 years ago

Replying to avryl:

As a reminder for the many bug reports and patches to come, make your diffs not from /src but from your install.

Doesn't matter I think? I always make my patches form src.

I think it was an initial requirement for #27023, but looking at https://github.com/aaronjorbin/grunt-patch-wordpress/issues/3, seems like it should handle both now.

TortoiseSVN complains about a mismatched path though :)

Note: See TracTickets for help on using tickets.