WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30557 closed defect (bug) (fixed)

Screen Options: change the "editor-expand" checkbox description to include DFW

Reported by: azaozz Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.0
Component: Text Changes Keywords: has-patch dev-feedback
Focuses: ui, docs, administration Cc:
PR Number:

Description

This checkbox controls both editor-expand and DFW v2. When it is unchecked the "Fullscreen" button in disabled and greyed out.

Attachments (1)

30557.diff (765 bytes) - added by kpdesign 5 years ago.

Download all attachments as: .zip

Change History (18)

#1 @azaozz
5 years ago

Perhaps:

Expand the editor to match the window height and enable use of Distraction Free Writing.

Or maybe:

Focus on writing: auto resize the editor and enable use of Distraction Free Writing mode.

#2 @DrewAPicture
5 years ago

  • Component changed from Administration to Text Changes
  • Focuses docs administration added
  • Keywords needs-patch added

@kpdesign
5 years ago

#3 @kpdesign
5 years ago

  • Keywords has-patch added; needs-patch removed

"Expand the editor to match the window height, and enable distraction-free writing." is concise, and will allow us to build on the existing string.

30557.diff contains the above text change.

#4 follow-up: @johnbillion
5 years ago

  • Summary changed from Screen Options: change the "editor-expand" chackbox description to include DFW to Screen Options: change the "editor-expand" checkbox description to include DFW

Can the DFW button be hidden rather than just greyed out when editor expand is disabled?

#5 follow-ups: @johnbillion
5 years ago

  • Keywords dev-feedback added

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

#6 in reply to: ↑ 5 @kpdesign
5 years ago

Replying to johnbillion:

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

Because there are users who don't care for it, and the checkbox was added in Screen Options to allow them to turn it off (see r29336 and r29588).

#7 in reply to: ↑ 5 @GregLone
5 years ago

Replying to johnbillion:

In fact, why is there a screen option for editor expand? It seems like something that should always just be on.

What's the use case for disabling it?

Simple: a veeeeeeeeery long post with meta boxes under the editor (scroll, scroll, scroll, scroll...).
I personnally hate this feature :/

#8 in reply to: ↑ 4 @azaozz
5 years ago

Replying to johnbillion:

Can the DFW button be hidden rather than just greyed out when editor expand is disabled?

Sure, it would only take a little of CSS. I remember this being discussed somewhere, don't seem to be able to find it in https://wordpress.slack.com/messages/feature-focus/. Think it was not hidden to make it more discoverable (the old DFW button was visible at all times). However the problem of "how to enable DFW when editor-scrolling is off" seems worse.

#9 @azaozz
5 years ago

Related: #30568.

#10 follow-up: @kpdesign
5 years ago

With #30568 in, do we still want to make this change to the Screen Options text?

#11 in reply to: ↑ 10 @azaozz
5 years ago

Replying to kpdesign:

Sure, will make it better/accurate.

#12 @azaozz
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [30718]:

Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557.

#13 @helen
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I am not loving this sentence at all, and I think it's confusing to those who might wonder why the two things are coupled together. Is there something we can come up with to refer to it all together that doesn't feel like a code name? "Enable the adaptive editor", maybe?

This ticket was mentioned in Slack in #core by azaozz. View the logs.


5 years ago

#15 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from reopened to closed

In 30734:

Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557.

This ticket was mentioned in Slack in #polyglots by ocean90. View the logs.


5 years ago

#17 @xibe
5 years ago

Folks, please see #30657 for another string that was impacted by this string change.

Note: See TracTickets for help on using tickets.