String: "Editor Expand" mention needs to be updated

[xibe]

In ticket #30557, the "editor-expand" checkbox description was changed from "Expand the editor to match the window height." to "Enable full-height editor and distraction-free functionality."

But that string is mentionned elsewhere: in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L288, the Help screen says "This feature is not available for old browsers or devices with small screens, and requires that Editor Expand be enabled in Screen Options."

Since there is no mention of "expand" in the new string, this can confuse users (I know it confused me).

I suggest to change the edit-form-advanced.php string to this: 'This feature is not available for old browsers or devices with small screens, and requires that the "Enable full-height editor and distraction-free functionality" option (at the bottom of the Screen Options) be enabled.'

Ok, it's a mouthful so there might be better options. But at least the directions are clear.

Patch coming up next.

[xibe]

Updated string.

[johnbillion]

That string is a mouthful. I wonder if we can improve the whole paragraph.

[kpdesign]

How about:

This feature is not available for old browsers or devices with small screens, and requires the full-height editor be enabled in Screen Options.

This would be a smaller change to the string (that Editor Expand to the full-height editor), and would match the editor text for the checkbox.

[xibe]

Good for me. It lacks the "bottom of Screen Options" part, but maybe I'm the one too thick to not look in the right place :)

[xibe]

Simpler string by kpdesign.

[azaozz]

30657-2.diff looks good.

[ocean90]

30657-2.diff​ is fine. It's the same as I proposed on ​Slack.

[johnbillion]

Yep go for it

[nacin]

If we're going to change this string, I'd like to remove reference to "Fullscreen". On the about page, Mark and I toyed with new terminology for this, as well. (See #30435.)

We can safely change this string post-RC.

[ocean90]

So, how should we name the icon? Does it need a name?

[xibe]

Replying to nacin:

If we're going to change this string, I'd like to remove reference to "Fullscreen". On the about page, Mark and I toyed with new terminology for this, as well. (See #30435.)

We can safely change this string post-RC.

We a couple of days away from release, and the strings are all but frozen. This should be committed quickly if we intend to have something for 4.1. @nacin, what's your definitive take on the "fullscreen" wording?

[nacin]

In 30890:

Call it 'Distraction-free writing mode' and update the help string. fixes #30657.

[pavelevap]

Not for 4.1?

[johnbillion]

In 30892:

Call it 'Distraction-free writing mode' and update the help string.

Merges [30890] to the 4.1 branch.

Fixes #30657.

[pavelevap]

We need similar strings "Distraction-Free Writing" for pointer title and "Distraction-free writing" for about page subtitle?