WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30657 closed enhancement (fixed)

String: "Editor Expand" mention needs to be updated

Reported by: xibe Owned by: nacin
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Help/About Keywords: has-patch i18n-change commit fixed-major
Focuses: Cc:

Description

In ticket #30557, the "editor-expand" checkbox description was changed from "Expand the editor to match the window height." to "Enable full-height editor and distraction-free functionality."

But that string is mentionned elsewhere: in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/edit-form-advanced.php#L288, the Help screen says "This feature is not available for old browsers or devices with small screens, and requires that Editor Expand be enabled in Screen Options."

Since there is no mention of "expand" in the new string, this can confuse users (I know it confused me).

I suggest to change the edit-form-advanced.php string to this: 'This feature is not available for old browsers or devices with small screens, and requires that the "Enable full-height editor and distraction-free functionality" option (at the bottom of the Screen Options) be enabled.'

Ok, it's a mouthful so there might be better options. But at least the directions are clear.

Patch coming up next.

Attachments (2)

30657.diff (1.6 KB) - added by xibe 6 years ago.
Updated string.
30657-2.diff (1.5 KB) - added by xibe 6 years ago.
Simpler string by kpdesign.

Download all attachments as: .zip

Change History (21)

@xibe
6 years ago

Updated string.

#1 @xibe
6 years ago

  • Keywords has-patch 2nd-opinion added

This ticket was mentioned in Slack in #polyglots by xavier. View the logs.


6 years ago

#3 @johnbillion
6 years ago

  • Milestone changed from Awaiting Review to 4.1

That string is a mouthful. I wonder if we can improve the whole paragraph.

#4 @kpdesign
6 years ago

How about:

This feature is not available for old browsers or devices with small screens, and requires the full-height editor be enabled in Screen Options.

This would be a smaller change to the string (that Editor Expand to the full-height editor), and would match the editor text for the checkbox.

#5 @xibe
6 years ago

Good for me. It lacks the "bottom of Screen Options" part, but maybe I'm the one too thick to not look in the right place :)

Last edited 6 years ago by xibe (previous) (diff)

@xibe
6 years ago

Simpler string by kpdesign.

#6 @azaozz
6 years ago

  • Keywords commit added; 2nd-opinion removed

30657-2.diff looks good.

This ticket was mentioned in Slack in #core by azaozz. View the logs.


6 years ago

#8 @johnbillion
6 years ago

  • Keywords i18n-change added

#9 @ocean90
6 years ago

  • Keywords i18n-change removed

30657-2.diff is fine. It's the same as I proposed on Slack.

#10 @johnbillion
6 years ago

Yep go for it

#11 @ocean90
6 years ago

  • Keywords i18n-change added

#12 follow-up: @nacin
6 years ago

  • Keywords i18n-change removed

If we're going to change this string, I'd like to remove reference to "Fullscreen". On the about page, Mark and I toyed with new terminology for this, as well. (See #30435.)

We can safely change this string post-RC.

#13 @ocean90
6 years ago

  • Keywords i18n-change added; commit removed

So, how should we name the icon? Does it need a name?

#14 in reply to: ↑ 12 @xibe
6 years ago

Replying to nacin:

If we're going to change this string, I'd like to remove reference to "Fullscreen". On the about page, Mark and I toyed with new terminology for this, as well. (See #30435.)

We can safely change this string post-RC.

We a couple of days away from release, and the strings are all but frozen. This should be committed quickly if we intend to have something for 4.1. @nacin, what's your definitive take on the "fullscreen" wording?

#15 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 30890:

Call it 'Distraction-free writing mode' and update the help string. fixes #30657.

#16 @pavelevap
6 years ago

Not for 4.1?

#17 @johnbillion
6 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#18 @johnbillion
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30892:

Call it 'Distraction-free writing mode' and update the help string.

Merges [30890] to the 4.1 branch.

Fixes #30657.

#19 @pavelevap
6 years ago

We need similar strings "Distraction-Free Writing" for pointer title and "Distraction-free writing" for about page subtitle?

Note: See TracTickets for help on using tickets.