WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#30739 closed defect (bug) (fixed)

Twenty Fifteen: Menu icon is not properly centered

Reported by: tenpura Owned by: lancewillett
Milestone: 4.1 Priority: low
Severity: minor Version: 4.1
Component: Bundled Theme Keywords: commit fixed-major
Focuses: rtl Cc:

Description

The menu icon on smaller screens does not seem to be properly centered.

Adding display: block; to .secondary-toggle:before fix this for me.

.secondary-toggle:before {
	color: #333;
	content: "\f419";
	line-height: 42px;
	position: relative;
	top: -1px;
	left: 0;
	display: block;
}

Attachments (3)

2015-menu-icon.png (345 bytes) - added by tenpura 4 years ago.
languages.zip (7.4 KB) - added by tenpura 4 years ago.
latest pomo
30739.diff (1.4 KB) - added by iamtakashi 4 years ago.

Download all attachments as: .zip

Change History (20)

#1 @lancewillett
4 years ago

  • Keywords reporter-feedback added

Hi tenpura, thanks for this ticket. Can you please add a bit more information? Which small screens did you see this with? Can you add device and OS info so we can repeat it?

Is it WP trunk and latest version of Twenty Fifteen from trunk?

Can you repeat the bug on the Twenty Fifteen demo site: https://twentyfifteendemo.wordpress.com/ (screenshot: https://cloudup.com/cYVXHmE6iQm).

#2 @tenpura
4 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

I'm sorry. The problem won't be reproduced with the clean install of latest trunk and branches/4.1. Something was wrong with my old test environment.

#3 @tenpura
4 years ago

  • Resolution worksforme deleted
  • Status changed from closed to reopened

Ok. I found out the way to reproduce the problem. This occurs only when twentyfifteen-ja.mo is loaded. Do you think of any section that can cause this in the language file?

@tenpura
4 years ago

latest pomo

#4 @markoheijnen
4 years ago

  • Keywords reporter-feedback removed

#30743 also mentioned this problem when the locale is RTL

#5 @johnbillion
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

Thanks for the report tenpura. Let's fix this as part of #30743.

#6 @johnbillion
4 years ago

  • Milestone set to 4.1
  • Resolution duplicate deleted
  • Status changed from closed to reopened

Change of plan.

This ticket was mentioned in Slack in #core by helen. View the logs.


4 years ago

#8 @johnbillion
4 years ago

  • Focuses rtl added
  • Keywords needs-patch added
  • Milestone changed from 4.1 to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

This appears to only be reproducible if you zoom in and then zoom back out again.

Bumping for now, unless anyone comes up with a rock solid reason why this happens and an accompanying patch.

Only affects RTL.

#9 @iamtakashi
4 years ago

While I was looking at #30743, I've managed to reproduce the bug without zooming.

Specifying width for the pseudo element will fix the issue.

Patch incoming shortly.

Last edited 4 years ago by iamtakashi (previous) (diff)

@iamtakashi
4 years ago

#10 @iamtakashi
4 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.1

#11 @lancewillett
4 years ago

  • Keywords needs-testing added

#12 @alex-ye
4 years ago

@iamtakashi Tested, Working fine!.. Thanks again. :)

#13 @lancewillett
4 years ago

  • Keywords commit added; needs-testing removed

#14 @lancewillett
4 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from reopened to closed

In 30955:

Twenty Fifteen: ensure menu icon is properly centered for RTL views on small screens.

Props iamtakashi, fixes #30739.

#15 @lancewillett
4 years ago

  • Keywords fixed-major added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

#16 @nacin
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30958:

Twenty Fifteen: Final RTL, editor-style, and search padding fixes.

Merges [30953], [30955], [30956] to the 4.1 branch.

Props iamtakashi, alex-ye.
fixes #30744, #30739, #30746.

#17 @tenpura
4 years ago

  • Japanese is not RTL.
  • Why did this happen when twentyfifteen-ja.mo is loaded?

It seems that underlying issues remain unclear.

Note: See TracTickets for help on using tickets.