WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#30754 closed defect (bug) (fixed)

Syntax error being reported in customize-controls.js qunit tests

Reported by: johnbillion Owned by: jorbin
Milestone: 4.2 Priority: normal
Severity: normal Version: 4.1
Component: Customize Keywords: needs-testing needs-unit-tests has-patch
Focuses: javascript Cc:

Description

Previously: #30701 and [30919].

Travis is failing the qunit tests due to a syntax error: https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/44355927

Attachments (1)

30754.patch (570 bytes) - added by ocean90 4 years ago.

Download all attachments as: .zip

Change History (4)

@ocean90
4 years ago

#1 @ocean90
4 years ago

  • Keywords has-patch added

#2 @jorbin
4 years ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 30989:

Add jQuery UI Core as a dependency for qUnit tests

[30919] added more qUnit tests for the Customizer. One of the dependencies for these tests is qUnit. Otherwise we end up with an error due to an unsupported pseudo.

https://travis-ci.org/aaronjorbin/develop.wordpress/jobs/44873635#L425 shows an example of the failing test.

Props ocean90.
see #30701.
Fixes #30754.

#3 @jorbin
4 years ago

  • Milestone changed from Awaiting Review to 4.2
Note: See TracTickets for help on using tickets.