Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30765 closed defect (bug) (fixed)

Menu with only one item shows "Move" text but no direction

Reported by: ipstenu's profile Ipstenu Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.2 Priority: normal
Severity: minor Version: 3.6
Component: Menus Keywords: good-first-bug has-patch
Focuses: Cc:

Description

Originally reported in alpha/beta

The word "move" shows below the Description.

Description
The description will be displayed in the menu if the current theme supports it.

Move

The code appears here: https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/nav-menu.php#L186

See attached image for a visual

Attachments (2)

wp41rc3-glitch.png (57.6 KB) - added by Ipstenu 10 years ago.
Example of the Move
30765.diff (1.0 KB) - added by kucrut 10 years ago.

Download all attachments as: .zip

Change History (10)

@Ipstenu
10 years ago

Example of the Move

#1 @kintopp
10 years ago

With reference to your reply to my original post on the alpha/beta forum, the theme in use was definitely Twenty-Fifteen. I verified it again now. But you're correct in that the WP release was not 4.1RC3 any more but 4.2alpha. I forgot that I updated it at some point. I can't be positive that it was before the screenshot was taken. It's certainly present in 4.2alpha.

#2 @Ipstenu
10 years ago

I can reproduce this on any theme, on WP 4.0 and 4.1, so it's not related to either twentyfifteen or WP 4.1 :)

#3 @nacin
10 years ago

  • Keywords good-first-bug added
  • Milestone changed from Awaiting Review to 4.2
  • Severity changed from normal to minor
  • Version changed from 4.0 to 3.6

Funny bug. This came in during 3.6 I think.

@kucrut
10 years ago

#4 @kucrut
10 years ago

  • Keywords has-patch added

30765.diff hides the .field-move altogether when there's only one menu item. It also make sure that the texts are updated when a menu item is removed.

Last edited 10 years ago by kucrut (previous) (diff)

#5 @valendesigns
10 years ago

Tested the patch and it works as expected.

#6 @iCaleb
10 years ago

Tested the patch using a cursor and keyboard. All seems good.

#7 @SergeyBiryukov
10 years ago

Introduced in [23727].

#8 @SergeyBiryukov
10 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 31320:

Menus: Don't display "Move" text without direction if there is only one menu item.

props kucrut for initial patch.
fixes #30765.

Note: See TracTickets for help on using tickets.