WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#31216 closed enhancement (fixed)

Media Library HTTP Error Filenames

Reported by: jumpmuz Owned by: helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.1
Component: Media Keywords: has-patch
Focuses: ui Cc:

Description

This is a small UI bug I found while uploading lots of files. The file names don't show in full, making it difficult to find the right file to fix and re-upload.

e.g. 2015_FUJI_AB….1D_side.jpg

Attachments (2)

Screen Shot 2015-02-03 at 9.04.59 am.png (39.8 KB) - added by jumpmuz 7 years ago.
HTTP Error Filenames
31216.diff (922 bytes) - added by helen 7 years ago.

Download all attachments as: .zip

Change History (9)

@jumpmuz
7 years ago

HTTP Error Filenames

#1 @helen
7 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Thanks for the report, jumpmuz! I'm not sure if we set this or if it's plupload, but I agree that we should show more of the filename in this situation. The other place this shows is in the media modal's sidebar (when you're adding media to a post), which has more limited space. It may not be so bad to show the full filename there either, though. We could possibly also explore something like CSS text-overflow, though you'd lose the file extension reference, which I imagine is why this truncates in the middle at the moment.

@helen
7 years ago

#2 @helen
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 4.3

We removed the "Error" label in #31874, so visually I see no problems just showing the whole filename. The attached patch is just a quick hack to see the effects - I think we'd want to maybe actually remove wp.media.truncate if a plugins repo search turns up nothing, and then I'm not sure filename actually needs to be a function either. Seeking opinions from those with more investment in the overall media architecture.

This ticket was mentioned in Slack in #design by helen. View the logs.


7 years ago

#4 @obenland
7 years ago

  • Owner set to helen
  • Status changed from new to assigned

There's been no movement in 5 weeks, @helen do you think it'll make it before beta?

#5 @helen
7 years ago

It's a very small change, would want to run a plugin repo search (I seriously doubt anybody is using that truncate function) and @wonderboymusic or @ericlewis to opine on how much we can cut out given that there are a couple functions that look pretty specific to this.

This ticket was mentioned in Slack in #core by helen. View the logs.


7 years ago

#7 @wonderboymusic
7 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32908:

In wp.media.view.UploaderStatus.filename(), don't truncate the filename.

Props helen.
Fixes #31216.

Note: See TracTickets for help on using tickets.