WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 years ago

#31365 reviewing enhancement

Improve actions links for current theme on themes.php

Reported by: MikeHansenMe Owned by:
Milestone: Future Release Priority: low
Severity: normal Version:
Component: Themes Keywords: has-patch needs-refresh
Focuses: administration Cc:

Description

The links are not escaped in themes.php related #30952

Attachments (2)

31365.diff (4.0 KB) - added by MikeHansenMe 3 years ago.
31365.2.diff (1.8 KB) - added by MikeHansenMe 3 years ago.

Download all attachments as: .zip

Change History (12)

@MikeHansenMe
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Themes
  • Focuses administration added

#2 @MikeHansenMe
3 years ago

  • Keywords has-patch added

#3 @DrewAPicture
3 years ago

  • Milestone changed from Awaiting Review to 4.2

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

#5 @DrewAPicture
3 years ago

@MikeHansenMe: Can we get a version of 31365.diff minus the unrelated whitespace changes? Also, seems like we should be able to get away with just using admin_url() as we do elsewhere in the admin.

@MikeHansenMe
3 years ago

#6 @MikeHansenMe
3 years ago

@DrewAPicture updated with only the line changes. Also used admin_url like other places in the admin.

This ticket was mentioned in Slack in #core by drew. View the logs.


3 years ago

#8 @DrewAPicture
3 years ago

  • Keywords commit added

31365.2.diff looks good to me. It's worth having core set a good example for itself, though I think the add_query_arg() bits might be a bit much. Moving for commit consideration.

#9 @ocean90
3 years ago

  • Owner set to ocean90
  • Status changed from new to reviewing

#10 @ocean90
3 years ago

  • Keywords needs-refresh added; commit removed
  • Milestone changed from 4.2 to Future Release
  • Priority changed from normal to low
  • Summary changed from links in themes.php are not escaped to Improve actions links for current theme on themes.php
  • Type changed from defect (bug) to enhancement

This code is led with // Pretend you didn't see this.. Rather than adding some admin_url() and add_query_arg() calls I would like to see this section rewritten. Currently it's just a copy of some code for the admin menu.

31365.2.diff will break the CSS rules for hiding custom header/background links, see trunk/src/wp-admin/css/admin-menu.css@31573#L616

Note: See TracTickets for help on using tickets.