Opened 12 years ago
Last modified 6 days ago
#31365 reviewing enhancement
Improve actions links for current theme on themes.php
| Reported by: | MikeHansenMe | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | Themes | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | administration |
Description
The links are not escaped in themes.php related #30952
Attachments (2)
Change History (13)
This ticket was mentioned in Slack in #core by drew. View the logs.
12 years ago
#6
@
12 years ago
@DrewAPicture updated with only the line changes. Also used admin_url like other places in the admin.
This ticket was mentioned in Slack in #core by drew. View the logs.
11 years ago
#8
@
11 years ago
- Keywords commit added
31365.2.diff looks good to me. It's worth having core set a good example for itself, though I think the add_query_arg() bits might be a bit much. Moving for commit consideration.
#10
@
11 years ago
- Keywords needs-refresh added; commit removed
- Milestone 4.2 → Future Release
- Priority normal → low
- Summary links in themes.php are not escaped → Improve actions links for current theme on themes.php
- Type defect (bug) → enhancement
This code is led with // Pretend you didn't see this.. Rather than adding some admin_url() and add_query_arg() calls I would like to see this section rewritten. Currently it's just a copy of some code for the admin menu.
31365.2.diff will break the CSS rules for hiding custom header/background links, see trunk/src/wp-admin/css/admin-menu.css@31573#L616
This ticket was mentioned in PR #13477 on WordPress/wordpress-develop by skikken.
6 days ago
#11
- Keywords needs-refresh removed
Trac ticket: https://core.trac.wordpress.org/ticket/31365
## Use of AI Tools
AI assistance: Yes
Tool(s): Claide
Model(s): Sonnet
Used for: Code Review
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
@MikeHansenMe: Can we get a version of 31365.diff minus the unrelated whitespace changes? Also, seems like we should be able to get away with just using
admin_url()as we do elsewhere in the admin.