WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 2 years ago

#31798 new defect (bug)

Editor: switch undo and redo in RTL

Reported by: yoavf Owned by:
Milestone: Future Release Priority: low
Severity: normal Version:
Component: Editor Keywords: has-patch needs-testing
Focuses: rtl Cc:

Description

The undo and redo icons in RTL should we switched.

LTR:
https://cloudup.com/cHOxlUfHbAp

Current RTL:
https://cloudup.com/cizBcGBMkCa

Proper RTL:
https://cloudup.com/cSCyiF_HxMA

Attachments (3)

31798.diff (416 bytes) - added by yoavf 4 years ago.
31798-gruntfile.diff (902 bytes) - added by yoavf 4 years ago.
31798.patch (1.5 KB) - added by iseulde 4 years ago.

Download all attachments as: .zip

Change History (16)

@yoavf
4 years ago

#1 follow-up: @ocean90
4 years ago

  • Component changed from Press This to Editor
  • Priority changed from normal to low
  • Summary changed from Press This: switch undo and redo in RTL to Editor: switch undo and redo in RTL
  • Version trunk deleted

This is not specific to Press This, rather Editor in all.

Related chats on Slack:

Maybe we should extend our swap-dashicons-left-right-arrows rule with these icons: trunk/Gruntfile.js@31875#L196

Last edited 4 years ago by ocean90 (previous) (diff)

#2 @yoavf
4 years ago

Thanks for reminding me of these conversations @ocean90. Indeed, this affects the general editor too.

To recap my personal opinion on icons in rtl: they don't necessarily need to be flipped, unless they represent some kind of directionality. In this case, they do.

#3 in reply to: ↑ 1 @yoavf
4 years ago

Replying to ocean90:

Maybe we should extend our swap-dashicons-left-right-arrows rule with these icons: trunk/Gruntfile.js@31875#L196

Oh nice, I never saw that beore (that's what I get for sitting out of dev cycles).

Anyway, swap-dashicons-left-right-arrows expects the values to be surrounded by double quotes, and we have (in this file, and probably other) content values surrounded by single quotes.

Should we improve the function to catch both, or do we have a guideline on how to surround content values this way or another?

Last edited 4 years ago by yoavf (previous) (diff)

#4 @yoavf
4 years ago

31798-gruntfile.diff does this via swap-dashicons-left-right-arrows. As a side effect, single quotes will be replaced by double quotes in content properties, in the rtl css.

@iseulde
4 years ago

This ticket was mentioned in Slack in #core-editor by iseulde. View the logs.


4 years ago

#7 @azaozz
4 years ago

  • Milestone changed from 4.2 to Future Release

I'm actually not sure if this will be more beneficial than annoying. Swapping buttons will definitely be annoying, the users will have to re-learn them. This sounds a bit like swapping right and left.

Also, is there a consensus: in all countries with RTL languages, which is considered to mean "forward", "right" or "left"? Perhaps some more input from people that are native RTL language speakers will be beneficial.

#8 @louyx
4 years ago

Speaking of Arabs, and I think this applies to all RTL languages speaker, in books you have left for forwards and right for backwards.

Also the UI is flipped in RTL so if you consider the page starts by the sidebar and moves in the other direction, it'll be on the right, and forwards will be to the left.

#9 follow-up: @iseulde
4 years ago

  • Keywords reporter-feedback added

@yoavf, any feedback?

#10 in reply to: ↑ 9 @yoavf
4 years ago

Replying to iseulde:

@yoavf, any feedback?

I still think we should switch - haven't tested your patch yet, will try to do that soon.

#11 @swissspidy
2 years ago

  • Keywords needs-testing added; reporter-feedback removed
  • Milestone changed from Future Release to 4.8

This ticket was mentioned in Slack in #core by flixos90. View the logs.


2 years ago

#13 @flixos90
2 years ago

  • Milestone changed from 4.8 to Future Release
Note: See TracTickets for help on using tickets.