Editor: switch undo and redo in RTL

[yoavf]

The undo and redo icons in RTL should we switched.

LTR:
​https://cloudup.com/cHOxlUfHbAp

Current RTL:
​https://cloudup.com/cizBcGBMkCa

Proper RTL:
​https://cloudup.com/cSCyiF_HxMA

[ocean90]

This is not specific to Press This, rather Editor in all.

Related chats on Slack:

• ​https://wordpress.slack.com/archives/polyglots/p1421001395000007
• ​https://wordpress.slack.com/archives/polyglots/p1418244541000323

Maybe we should extend our swap-dashicons-left-right-arrows rule with these icons: trunk/Gruntfile.js@31875#L196​

[yoavf]

Thanks for reminding me of these conversations @ocean90. Indeed, this affects the general editor too.

To recap my personal opinion on icons in rtl: they don't necessarily need to be flipped, unless they represent some kind of directionality. In this case, they do.

[yoavf]

Replying to ocean90:

Maybe we should extend our swap-dashicons-left-right-arrows rule with these icons: trunk/Gruntfile.js@31875#L196​

Oh nice, I never saw that beore (that's what I get for sitting out of dev cycles).

Anyway, swap-dashicons-left-right-arrows expects the values to be surrounded by double quotes, and we have (in this file, and probably other) content values surrounded by single quotes.

Should we improve the function to catch both, or do we have a guideline on how to surround content values this way or another?

[yoavf]

31798-gruntfile.diff​ does this via swap-dashicons-left-right-arrows. As a side effect, single quotes will be replaced by double quotes in content properties, in the rtl css.

[SergeyBiryukov]

Related: #21281

[azaozz]

I'm actually not sure if this will be more beneficial than annoying. Swapping buttons will definitely be annoying, the users will have to re-learn them. This sounds a bit like swapping right and left.

Also, is there a consensus: in all countries with RTL languages, which is considered to mean "forward", "right" or "left"? Perhaps some more input from people that are native RTL language speakers will be beneficial.

[louyx]

Speaking of Arabs, and I think this applies to all RTL languages speaker, in books you have left for forwards and right for backwards.

Also the UI is flipped in RTL so if you consider the page starts by the sidebar and moves in the other direction, it'll be on the right, and forwards will be to the left.

[iseulde]

@yoavf, any feedback?

[yoavf]

Replying to iseulde:

@yoavf, any feedback?

I still think we should switch - haven't tested your patch yet, will try to do that soon.