WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#32324 closed defect (bug) (fixed)

Media Library grid spinner hidden after bulk selection

Reported by: afercia Owned by: wonderboymusic
Milestone: 4.3 Priority: normal
Severity: normal Version: 4.2
Component: Media Keywords: has-patch
Focuses: ui, javascript Cc:

Description

Now that spinners are toggled using the CSS’s visibility property (see #22839), some minor breakage was expected to happen. To reproduce this:

  • go in the Media Library, grid mode
  • press the "Bulk Select" button
  • the spinner is now hidden with jQuery .hide() and gets an inline display: none, see screenshot
  • press "Cancel Selection"
  • now select a different month from the filter by date select
  • the spinner doesn't appear, it's still hidden with display: none

https://cldup.com/hEaOSFAT5U.png

Attachments (1)

32324.patch (1.9 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (4)

@afercia
6 years ago

#1 @afercia
6 years ago

In the proposed patch:

  • the spinner in the Media Library grid toolbar doesn't need to be hidden with jQuery

#2 @wonderboymusic
6 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to wonderboymusic
  • Status changed from new to assigned

#3 @wonderboymusic
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 32502:

In views/button/select-mode-toggle, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler method.

Props afercia.
Fixes #32324.

Note: See TracTickets for help on using tickets.