WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#32550 closed defect (bug) (fixed)

Media views: consider to remove the refresh-attachment link

Reported by: afercia Owned by: wonderboymusic
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.9
Component: Media Keywords: has-patch dev-feedback
Focuses: ui, javascript Cc:

Description

Related: #26550

The refresh-attachment link in /wp-includes/media-template.php seems to be unused since r27445. See in the screenshot below how it worked in WordPress 3.8

https://cldup.com/Lypw7hOS8K.png

Now that the image editor has been brought into the media modal I don't see any reason to keep this link, unless I'm missing something.

I'd propose to simply remove it together with the related JavaScript and CSS. Patch welcome :)

Attachments (1)

32550.patch (348.0 KB) - added by rommelxcastro 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @helen
5 years ago

Does this link actually appear anymore? I hadn't realized it was still in the code because I haven't seen it in so long. Let's definitely get rid of it, anyway.

#2 @rommelxcastro
5 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

hey guys here's a patch,

i still see some references to a .needs-refresh class, looks like this class is not being generate/used anywhere that the css file, i pretty confident we can remove it, please confirm

@rommelxcastro
5 years ago

#3 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 32909:

Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445].

Props rommelxcastro.
Fixes #32550.

#4 @netweb
5 years ago

  • Milestone changed from Awaiting Review to 4.3
Note: See TracTickets for help on using tickets.