WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#32582 closed defect (bug) (fixed)

Fix order of screen options on Appearance > Menus page

Reported by: bcole808 Owned by: obenland
Milestone: 4.3 Priority: normal
Severity: normal Version: 2.7
Component: General Keywords:
Focuses: ui, administration Cc:

Description

In the admin dashboard, under Appearance > Menus, on the Screen Options dropdown:

https://cdn.pbrd.co/images/13tpb8QK.png

The item for "Pages" should be first because that's how it is listed on the actual page.

Current wrong order:

Posts | Custom Links | Categories | Tags | Format | Pages

The correct order should be:

Pages | Posts | Custom Links | Categories | Tags | Format

(Originally referenced from this ticket: https://core.trac.wordpress.org/ticket/32440#comment:1)

Attachments (3)

32582.diff (1.3 KB) - added by swissspidy 4 years ago.
32582.2.diff (1.3 KB) - added by swissspidy 4 years ago.
Even simpler usort patch
32582.3.diff (731 bytes) - added by swissspidy 4 years ago.
After talking to obenland, we came up with a more straightforward solution. I tested it on different screens and also with a couple of plugins that add meta boxes to the menu screen. Works like a charm.

Download all attachments as: .zip

Change History (10)

#1 @swissspidy
4 years ago

Sounds absolutely reasonable to me. I will now create a patch for that as part of WordCamp Cologne Contributor Day! :)

@swissspidy
4 years ago

#2 @swissspidy
4 years ago

  • Component changed from Menus to General

The attached patch sorts meta box priorities so higher prioritized options will appear first. This fixes the reported problem, not only for this screen, but everywhere meta boxes are used.

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


4 years ago

@swissspidy
4 years ago

Even simpler usort patch

@swissspidy
4 years ago

After talking to obenland, we came up with a more straightforward solution. I tested it on different screens and also with a couple of plugins that add meta boxes to the menu screen. Works like a charm.

#4 @obenland
4 years ago

  • Milestone changed from Awaiting Review to 4.3
  • Owner set to obenland
  • Status changed from new to accepted

#5 @obenland
4 years ago

  • Version changed from trunk to 2.7

Introduced in [8712].

#6 @obenland
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 32707:

Sort screen options for meta boxes according to the meta box's priority.

Props swissspidy.
Fixes #32582.

#7 @helen
4 years ago

Glad to see this fixed everywhere, and let this be a lesson to ourselves about arbitrarily-English-named contexts. :)

Note: See TracTickets for help on using tickets.