Fix order of screen options on Appearance > Menus page

[bcole808]

In the admin dashboard, under Appearance > Menus, on the Screen Options dropdown:

The item for "Pages" should be first because that's how it is listed on the actual page.

Current wrong order:

Posts | Custom Links | Categories | Tags | Format | Pages

The correct order should be:

Pages | Posts | Custom Links | Categories | Tags | Format

(Originally referenced from this ticket: https://core.trac.wordpress.org/ticket/32440#comment:1)

[swissspidy]

Sounds absolutely reasonable to me. I will now create a patch for that as part of WordCamp Cologne Contributor Day! :)

[swissspidy]

The attached patch sorts meta box priorities so higher prioritized options will appear first. This fixes the reported problem, not only for this screen, but everywhere meta boxes are used.

[swissspidy]

Even simpler usort patch

[swissspidy]

After talking to obenland, we came up with a more straightforward solution. I tested it on different screens and also with a couple of plugins that add meta boxes to the menu screen. Works like a charm.

[obenland]

Introduced in [8712].

[obenland]

In 32707:

Sort screen options for meta boxes according to the meta box's priority.

Props swissspidy.
Fixes #32582.

[helen]

Glad to see this fixed everywhere, and let this be a lesson to ourselves about arbitrarily-English-named contexts. :)