List table: colour comment bubble according to the scheme

[iseulde]

On hover the bubble is dark blue, which looks a bit weird in different colour schemes.

See #32152.

[iseulde]

Maybe we could even consider colouring the grey too. Same colours as the view switch icons.

[iseulde]

If we use the same variables for the default scheme though, it would be black and red on hover...

[ocean90]

#33115 was marked as a duplicate.

[afercia]

Sorry, forgot this ticket and created a duplicate :) Adding a screenshot for visual reference of what's happening right now (Sunrise color scheme):

• when hovering the bubble with zero comments it becomes red
• hovering/focusing the bubbles with links gives always the blue from the default color scheme

[afercia]

With patch applied. Everything is working :) Not sure about the actual result in "Light" where the bubbles maybe are too... light, and in "Sunrise" where both approved and pending are red.

[iseulde]

Thanks for making those screenshots. Yes, I don't think the colours are good.
If we used the same variables for the default scheme the default colour of the bubble would be black (same as the menu background).

[iseulde]

It's probably better to have a grey variant as the default bubble colour and then the "active" colour for hover.

[iseulde]

Above patch: keep grey bubble, $highlight-color on hover, $highlight-color for unapproved bubble.

[afercia]

Replying to iseulde:

Thanks for making those screenshots.

You're welcome :) Tested last patch and maybe just the Light color scheme would need the color text to be adjusted, maybe always white?

[afercia]

Override color: $text-color; with color: $menu-highlight-text; for the Light color scheme. Please double check, not so familiar with Sass here :)

[markjaquith]

The dark text on red background is really difficult for me to see.

[helen]

I'm not really sure there's anything wrong with blue - links are blue, no matter the color scheme, and those are more directly surrounding and in context with the bubble than the menu chrome.

[markjaquith]

Replying to helen:

I'm not really sure there's anything wrong with blue - links are blue, no matter the color scheme

This is a good point.

I think we should punt this, as RC is imminent.

[obenland]

Let's look at it again in a future release.

[iseulde]

Then we still need to remove some remains.

[iseulde]

Done in [33453].

[afercia]

@iseulde anything left here or this can be closed? :)

[hellofromTonya]

Assuming everything is done here as it's been 4 years since marked as a close candidate. Closing as fixed. However, if there's more to do, please reopen.