#33391 closed defect (bug) (fixed)
Remove hardcoded characters from Audio/Video Playlist track listings
Reported by: | qco | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | Media | Keywords: | has-patch commit |
Focuses: | ui, javascript, template | Cc: |
Description
The javascript templates used for Audio and Video playlists (media.php line 1144) automatically hardcode quotes and dashes into the various elements of the playlist items. I believe it would be better to move these to a filter (or fully handle with CSS) on the data being passed to the javascript, rather than being hardcoded on the output. If we want to restyle the playlist output, we still get stuck with double quotes on titles and dashes on the artist listing.
Attachments (1)
Change History (9)
#2
@
9 years ago
- Owner set to wonderboymusic
- Resolution set to fixed
- Status changed from new to closed
In 33643:
#3
follow-up:
↓ 4
@
9 years ago
We are using in our language localized quotes, for example „
instead of “
, etc. CSS solution does not respect it :-(
#4
in reply to:
↑ 3
@
9 years ago
Replying to pavelevap:
We are using in our language localized quotes, for example
„
instead of“
, etc. CSS solution does not respect it :-(
That's understandable. Could those localized quotes (and the mdash on the artist line) be added in filters instead of hardcoded in the JS? It is otherwise relatively trivial to modify the design of the playlists in themes or plugins using CSS because the output is otherwise well structured, but these hardcoded characters make things unnecessarily strict in terms of output.
#5
@
9 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Let's give this another look
#6
@
9 years ago
- Keywords has-patch commit added
Let's add a new string, which can be modified using the gettext
filter if needed: 33391.patch.
I can do this - thanks for the report!