WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#35807 closed feature request (wontfix)

Use the site logo set in the customizer in wp-login.php

Reported by: benoitchantre Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.5
Component: Login and Registration Keywords: close
Focuses: ui Cc:

Description

Could the WordPress logo be replaced by the site logo (#33755) in the login page?

We can actually change the logo with a filter, but it would be nice to use the customizer for that.

Change History (15)

This ticket was mentioned in Slack in #core by chriscct7. View the logs.


5 years ago

#3 @chriscct7
5 years ago

  • Keywords needs-patch added

Milestoned conditional on #33755

#4 @chriscct7
5 years ago

  • Milestone changed from Awaiting Review to 4.5

#5 @celloexpressions
5 years ago

Are we sure that it makes more sense to use a logo (if present) rather than the icon? It's designed to use a square image currently (the WordPress mark, not the logo that also contains text).

Additionally, we can better predict the size of an icon than a logo; if we use the logo and its aspect ratio is extremely far from square, there could be significant issues with how it's displayed.

If we use the site logo here, that could mean having to turn on the UI for the option regardless of theme support, which would be really bad for decisions, not options. Even if we go with the logo when present, I'd prefer to fall back to the icon if there is no logo and not turn the logo UI on if the theme doesn't support it.

#6 @benoitchantre
5 years ago

I think it makes more sense to use a logo rather than an icon on a login page. You can give a look at the login page of Facebook, LinkedIn, Google, etc. Even if their brand is well known, they all use their logo, not their icon.

If the site logo is placed in the Site Identity section of the Customizer, it is probably not required to remove it when the theme doesn't support site-logo. The Site Identity is global: both back-end and front-end in my opinion.

Last edited 5 years ago by benoitchantre (previous) (diff)

This ticket was mentioned in Slack in #core by jorbin. View the logs.


5 years ago

#8 @mikeschroder
5 years ago

  • Keywords close added; needs-patch removed
  • Milestone 4.5 deleted

We're going to go the route of Theme Support in #33755.

Personally, I think that core shouldn't rebrand itself, and this idea is plugin territory.

Because #33755 is going in the direction of theme support, rather than a global logo, going to mark this for a suggested close, but I'm happy to see conversation continue in the ticket about the idea, and reopen if/when the idea of a global logo is in WordPress core.

#9 @celloexpressions
5 years ago

I still think site icon would be appropriate here. The current WP icon is displayed roughly at the "app icon" size. I see a lot of confusion between which site is being logged into, especially for newer users. This could reduce that confusion, while still maintaining core branding with the rest of the page design matching the admin. The site title is too subtle on the login page to convey context; a site icon would give a visual marker without the full weight of a logo.

#10 @johnbillion
5 years ago

@celloexpressions See #33597

#11 @celloexpressions
5 years ago

I mean using the site icon in place of the W mark above the login form, although it's of course good to have the site icon used as an icon on that page as well.

#12 @SergeyBiryukov
5 years ago

  • Milestone set to Awaiting Review

#13 @celloexpressions
5 years ago

I made a quick plugin with my suggestion for now and submitted to the repo, we'll see how that goes. I think it can be useful on sites with a large number of contributors or for users with a large number of sites, but I'm not sure that it makes sense for core to drop the WordPress branding here.

#14 @chriscct7
4 years ago

  • Version trunk deleted

#15 @celloexpressions
4 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version set to 4.5

@chriscct7 please don't remove the trunk version for tickets that are in fact related to things introduced in trunk. This field is useful for historical and tracking purposes.

The plugin I mentioned above is https://wordpress.org/plugins/login-site-icon/. Obviously there hasn't been much adoption of that, but I've found it to be helpful. Since logos are theme-specific and can't be used, and there are mixed opinions about whether site icons should be used here or whether we could live with losing the WordPress icon here in the first place, I'm closing this ticket for now in favor of plugins.

Note: See TracTickets for help on using tickets.