WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#38066 closed defect (bug) (worksforme)

4.6.1-pl_PL wp-config-sample.php wrong DB_ definitions causes installation problem

Reported by: asuder Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.6.1
Component: I18N Keywords: needs-testing
Focuses: Cc:

Description (last modified by SergeyBiryukov)

In Polish version 4.6.1-pl_PL in file wp-config-sample.php in MySQL settings section all definitions have additional space after define(

define( 'DB_NAME', 'nazwa_bazy_danych' );
define( 'DB_USER', 'nazwa_uzytkownika' );
define( 'DB_PASSWORD', 'haslo' );
define( 'DB_HOST', 'localhost' );
define( 'DB_CHARSET', 'utf8' );
define( 'DB_COLLATE', '' );

During installation this produces wp-config.php with no MySQL settings, because in wp-admin/setup-config.php preg_match pattern have no space:

if ( ! preg_match( '/^define\(\'([A-Z_]+)\',([ ]+)/', $line, $match ) )

After deleting this additional spaces installation works normal.

Change History (7)

#1 @SergeyBiryukov
4 years ago

  • Component changed from General to I18N
  • Description modified (diff)

#2 @SergeyBiryukov
4 years ago

Introduced in https://i18n.trac.wordpress.org/changeset/61664.

@iworks, could you fix the file?

Updating wp-config-sample.php for WP coding standards was previously discussed in #19870. The consensus at the time was to leave it as is.

#3 follow-up: @iworks
4 years ago

  • Keywords needs-testing added
Last edited 4 years ago by iworks (previous) (diff)

#4 in reply to: ↑ 3 ; follow-up: @SergeyBiryukov
4 years ago

Replying to iworks:

The change was reverted.

Thanks! Could you also rebuild the 4.6.1 release on https://pl.wordpress.org/releases/ with the new file?

#5 in reply to: ↑ 4 @iworks
4 years ago

Replying to SergeyBiryukov:

Thanks! Could you also rebuild the 4.6.1 release on https://pl.wordpress.org/releases/ with the new file?

Done.

#6 @asuder
4 years ago

  • Resolution set to worksforme
  • Status changed from new to closed

#7 @swissspidy
4 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.