WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 3 months ago

#39105 closed enhancement (wontfix)

Add target="_blank" to author website output in comment moderation

Reported by: joshua.strebel Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Comments Keywords: target-blank
Focuses: ui, accessibility Cc:

Description

On /wp-admin/edit-comments.php add target="_blank" on the <a href id="author_comment_url_###$" > link. The preview screenshot is not alway sufficient and a click refreshes the current browser page. Would a new window be cleaner?

Change History (9)

#1 in reply to: ↑ description @joshua.strebel
11 months ago

Replying to joshua.strebel:

On /wp-admin/edit-comments.php add target="_blank" on the <a href id="author_comment_url_###$" > link. The preview screenshot is not alway sufficient and a click refreshes the current browser page. Would a new window be cleaner?

Accessibility and other considerations may need to be investigated.

#2 @rianrietveld
7 months ago

  • Focuses accessibility added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 months ago

#4 @afercia
6 months ago

  • Keywords reporter-feedback added
  • Version 4.6.1 deleted

@joshua.strebel we've discussed this in today's accessibility meeting, struggling a bit to find this thing :) We suspect it's an Akismet feature, can you confirm please? If so, not related to WordPress core and should be reported to the plugin authors.

Last edited 6 months ago by afercia (previous) (diff)

#5 follow-up: @joshua.strebel
6 months ago

Checked with and without akismet enabled.

Action with Akisment:
Hover over link, shows a screenshot
Click on link, opens in same tab as wp-admin (replaces)

Action w/out akisment
Hover over link, nothing.
Click on link, opens in same tab as wp-admin (replaces)

See screenshot.
https://www.dropbox.com/s/olc8afyp60kre6w/screenshot407.jpg?dl=0

#6 in reply to: ↑ 5 @joshua.strebel
6 months ago

It's Line 688 in wp-admin/includes/class-wp-comments-list-table.php

<?php
//687 if ( ! empty( $author_url_display ) ) {
//688  printf( '<a href="%s">%s</a><br />', esc_url( $author_url ), esc_html( $author_url_display ) );
//689 }

Replying to joshua.strebel:

Checked with and without akismet enabled.

Action with Akisment:
Hover over link, shows a screenshot
Click on link, opens in same tab as wp-admin (replaces)

Action w/out akisment
Hover over link, nothing.
Click on link, opens in same tab as wp-admin (replaces)

See screenshot.
https://www.dropbox.com/s/olc8afyp60kre6w/screenshot407.jpg?dl=0

#7 @afercia
5 months ago

  • Keywords target-blank added

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 months ago

#9 @joedolson
3 months ago

  • Keywords reporter-feedback removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The general principle for links in web accessibility is to avoid opening links in a new window.

While it's allowable to do it if there's a full textual disclosure that the link will open in a new window, the accessibility feels that this would lead to a significant amount of additional visual and audio noise on the page, and is not justified given that it's a relatively trivial context menu or keyboard combination option to open a link in a new tab from within the browser.

Note: See TracTickets for help on using tickets.