WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

#39208 closed defect (bug) (invalid)

Additional CSS placeholder text inconsistent with help button placement

Reported by: hvianna Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Customize Keywords:
Focuses: ui Cc:
PR Number:

Description

The placeholder text (comment) for additional CSS reads:

/* You can add your own CSS here. Click the help icon above to learn more. */

But the help button is actually placed below the textarea.

Change History (9)

#1 @swissspidy
3 years ago

  • Component changed from Text Changes to Customize

For accessibility reasons we probably shouldn't mention the location at all.

#2 follow-ups: @afercia
3 years ago

@hvianna maybe because you're using Jetpack custom css, it adds a Help link at the bottom. WordPress has only the help button above the textarea. See screenshot:

https://cldup.com/Xjzzxgm8T6.png

Also, the two icons give access to different help resources. Maybe the Jetpack link should clarify that it specifically refers to Jetpack.

@swissspidy yep maybe a better wording would help. In [37680] we've changed upper left in favour of above, I think it's OK because it suggests a "logical" position and not a "visual" position. Any improvements welcome :)

#3 @celloexpressions
3 years ago

  • Keywords close added

Jetpack should integrate with the core help button by replacing or extending the custom_css section's description via $wp_customize->get_section( 'custom_css' )->description = __( 'help text' );. There's no need to add another button on their end as that would only cause confusion and fragment the documentation. cc @georgestephanis

#4 in reply to: ↑ 2 @hvianna
3 years ago

Replying to afercia:

@hvianna maybe because you're using Jetpack custom css, it adds a Help link at the bottom. WordPress has only the help button above the textarea. See screenshot:

I'm really sorry for the confusion, I should've paid more attention to the screen. Thank you for clearing that out!

This ticket was mentioned in Slack in #core-customize by celloexpressions. View the logs.


3 years ago

#6 follow-up: @georgestephanis
3 years ago

Placement was directed by @folletto -- I'll follow up with him privately for our help location or overwriting Core's link target.

#7 in reply to: ↑ 6 @folletto
3 years ago

Replying to georgestephanis:

Placement was directed by @folletto -- I'll follow up with him privately for our help location or overwriting Core's link target.

The suggestion in this thread is meant to happen. We simply didn't make it in time for the release.
So I confirm, ideally it should just override the global (?) icon.

The background of that reason is that Jetpack is basically a step ahead implementing the Core's design proposal outlined here: #38707

#8 in reply to: ↑ 2 @jeherve
3 years ago

Replying to afercia:

@swissspidy yep maybe a better wording would help. In [37680] we've changed upper left in favour of above, I think it's OK because it suggests a "logical" position and not a "visual" position. Any improvements welcome :)

If we ever make changes to that help message, it might be worth clarifying here in that message, as some site owners take this a bit too literally and paste their CSS right after here, in the CSS comment.

#9 @pento
5 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.