Opened 8 years ago
Closed 6 years ago
#39738 closed defect (bug) (fixed)
Twenty Seventeen: Cannot resize image in the post editor due to a css rule
Reported by: | mihaivalentin | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.0.2 | Priority: | normal |
Severity: | normal | Version: | 4.7.2 |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch fixed-5.0 |
Focuses: | Cc: |
Description
WordPress 4.7.2, TwentySeventeen theme, wp-admin, Chrome Windows/Linux latest
- trying to add an image to a post
- try to resize using the resize handles
The image does not resize.
After some investigation, the problem is line 336 of editor-styles.css from the twentyseventeen theme. https://github.com/WordPress/WordPress/blob/4.7.2/wp-content/themes/twentyseventeen/assets/css/editor-style.css#L336
The problem is that the comment states that it is for IE8, but it is also used in modern browsers. Removing this property works and makes the image resize possible.
Can you please investigate this?
Thanks!
Attachments (2)
Change History (18)
#1
@
8 years ago
- Component changed from Themes to Bundled Theme
- Summary changed from Cannot resize image in the post editor, only on twentyseventeen theme, due to a css rule to Twenty Seventeen: Cannot resize image in the post editor due to a css rule
This ticket was mentioned in Slack in #core-themes by rdall. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by rdall. View the logs.
6 years ago
#5
@
6 years ago
- Milestone changed from Awaiting Review to 4.9.9
- Owner set to SergeyBiryukov
- Status changed from new to accepted
@
6 years ago
Drop support for IE8 since it's not supported anymore by WordPress Admin and this line is breaking image resizing
#6
@
6 years ago
- Keywords has-patch added; needs-patch removed
- Version changed from 4.7.2 to 4.9.8
Hi, Welcome to WordPress Trac @mihaivalentin :)
Thanks for the issue, it's a good catch!
I tested removing the CSS declaration you quoted, and it seems to work fine.
I'd say we can remove that line since WordPress Admin doesn't support IE8 anymore.
Cheers,
Jb
#7
@
6 years ago
- Version changed from 4.9.8 to 4.7.2
@audrasjb Note that the version field indicates the version where the issue was first reported or introduced.
#12
@
6 years ago
- Keywords commit added
Thanks for the report, @mihaivalentin, and for the patch, @audrasjb!
This update fixes the issue for me! As mentioned, the TinyMCE editor no longer supports IE8 -- in that browser only the text view is displayed, so this style isn't doing anything.
#13
@
6 years ago
Adding a note that I made an error in missing that #45580 was a duplicate of this ticket.
@subrataemfluence took the time to create a patch there, and should also get props for the work on this issue (thanks @subrataemfluence!).
I reported this on the WordPress Forms and can confirm the bug.
https://wordpress.org/support/topic/can-not-adjust-image-size-without-caption/
Using WordPress 4.7.4
Twenty Seventeen Version: 1.6
PHP 7.2.7
Tried both Chrome & FireFox, three different installs and two different hosting providers. All resulted in the same issue.
See Screencast:
https://cloudup.com/ieWsxqRouvq