WordPress.org

Make WordPress Core

Opened 15 months ago

Closed 8 months ago

#40184 closed enhancement (fixed)

Twenty Seventeen: the tag cloud widget should output a list

Reported by: sami.keijonen Owned by: sami.keijonen
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch tag-cloud needs-testing
Focuses: accessibility Cc:

Description

In ticket #35566 there is new tag cloud widget coming up with accessibility improvements. For bundled themes there is also general ticket #40138 for tag cloud widget.

This is ticket for Twenty Seventeen to output tag cloud widget as a list.

  • It's better for accessibility.
  • Remain the same styles.
  • Remove unnecessary !important rules.

Twenty Sixteen have an example how to use widget_tag_cloud_args for same font size. Let's add $args['format'] = 'list' in there.

Patch is coming up.

Attachments (6)

40184.diff (2.2 KB) - added by sami.keijonen 15 months ago.
Tag Cloud Widget.png (3.4 KB) - added by lukecavanagh 15 months ago.
Tag Cloud Widget - Twenty Seventeen
40184.1.diff (2.2 KB) - added by sami.keijonen 12 months ago.
40184.2.diff (2.2 KB) - added by sami.keijonen 8 months ago.
Screen Shot 2017-10-03 at 7.35.45 PM.png (26.3 KB) - added by davidakennedy 8 months ago.
Tag Cloud in RTL
40184.2.patch (421 bytes) - added by davidakennedy 8 months ago.
Adds RTL styles for new ul based tag cloud.

Download all attachments as: .zip

Change History (35)

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


15 months ago

@lukecavanagh
15 months ago

Tag Cloud Widget - Twenty Seventeen

#2 @lukecavanagh
15 months ago

@sami.keijonen

Patch applies cleanly and works as expected.

#3 @lukecavanagh
15 months ago

  • Keywords has-patch added

#4 @sami.keijonen
15 months ago

Thanks @lukecavanagh for testing!

This ticket was mentioned in Slack in #accessibility by sami.keijonen. View the logs.


14 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


14 months ago

#7 @afercia
14 months ago

  • Keywords tag-cloud added
  • Milestone changed from Awaiting Review to 4.8

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


13 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


13 months ago

#10 @jbpaul17
13 months ago

  • Milestone changed from 4.8 to 4.8.1

Punting to 4.8.1 per today's bug scrub.

This ticket was mentioned in Slack in #accessibility by adamsoucie. View the logs.


13 months ago

#12 @sami.keijonen
12 months ago

Now that new tag cloud widget is in trunk I added new 40184.1.diff where I only changed version number to 1.3: @since Twenty Seventeen 1.3.

#13 @afercia
11 months ago

  • Milestone changed from 4.8.1 to 4.9

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


10 months ago

#15 @afercia
10 months ago

  • Version changed from 4.8 to 4.7

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


10 months ago

This ticket was mentioned in Slack in #accessibility by sergey. View the logs.


10 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 months ago

#19 @afercia
8 months ago

  • Owner set to sami.keijonen
  • Status changed from new to assigned

#20 @sami.keijonen
8 months ago

I modified version number in the 40184.2.diff and added space after @param.

Tested that markup changes to list format and design keeps the same.

In the widget settings Show tag counts also works as should.

Screenshot before:

https://cldup.com/ndk1fKnE3V-3000x3000.png

Screenshot after:

https://cldup.com/DI5ReSMKpx.png

#21 @jbpaul17
8 months ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 months ago

#24 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41703:

Twenty Seventeen: Change tag cloud format to a list (<ul>) for better semantics and accessibility.

List markup allows screen reader users to know in advance how many tags are within the list.

Props sami.keijonen.
Fixes #40184.

This ticket was mentioned in Slack in #accessibility by davidakennedy. View the logs.


8 months ago

#26 @davidakennedy
8 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for the work here @sami.keijonen and for the merge @SergeyBiryukov!

It looks like this also needs RTL styles since we're floating some things and applying margins. See:

https://core.trac.wordpress.org/attachment/ticket/40184/Screen%20Shot%202017-10-03%20at%207.35.45%20PM.png

I noticed this also in #40138.

@davidakennedy
8 months ago

Adds RTL styles for new ul based tag cloud.

#27 @sami.keijonen
8 months ago

Thanks! I forgot all about the RTL styles.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


8 months ago

#29 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41754:

Twenty Seventeen: After [41703], adjust RTL styles for tag cloud widget.

Props davidakennedy.
Fixes #40184.

Note: See TracTickets for help on using tickets.