Twenty Seventeen: the tag cloud widget should output a list

[sami.keijonen]

In ticket #35566 there is new tag cloud widget coming up with accessibility improvements. For bundled themes there is also general ticket #40138 for tag cloud widget.

This is ticket for Twenty Seventeen to output tag cloud widget as a list.

• It's better for accessibility.
• Remain the same styles.
• Remove unnecessary !important rules.

Twenty Sixteen have an example how to use widget_tag_cloud_args for same font size. Let's add $args['format'] = 'list' in there.

Patch is coming up.

[lukecavanagh]

Tag Cloud Widget - Twenty Seventeen

[lukecavanagh]

@sami.keijonen

Patch applies cleanly and works as expected.

[sami.keijonen]

Thanks @lukecavanagh for testing!

[jbpaul17]

Punting to 4.8.1 per today's bug scrub.

[sami.keijonen]

Now that new tag cloud widget is in trunk I added new 40184.1.diff where I only changed version number to 1.3: @since Twenty Seventeen 1.3.

[sami.keijonen]

I modified version number in the 40184.2.diff and added space after @param.

Tested that markup changes to list format and design keeps the same.

In the widget settings Show tag counts also works as should.

Screenshot before:

Screenshot after:

[SergeyBiryukov]

In 41703:

Twenty Seventeen: Change tag cloud format to a list (<ul>) for better semantics and accessibility.

List markup allows screen reader users to know in advance how many tags are within the list.

Props sami.keijonen.
Fixes #40184.

[davidakennedy]

Tag Cloud in RTL

[davidakennedy]

Thanks for the work here @sami.keijonen and for the merge @SergeyBiryukov!

It looks like this also needs RTL styles since we're floating some things and applying margins. See:

https://core.trac.wordpress.org/attachment/ticket/40184/Screen%20Shot%202017-10-03%20at%207.35.45%20PM.png

I noticed this also in #40138.

[davidakennedy]

Adds RTL styles for new ul based tag cloud.

[sami.keijonen]

Thanks! I forgot all about the RTL styles.

[SergeyBiryukov]

In 41754:

Twenty Seventeen: After [41703], adjust RTL styles for tag cloud widget.

Props davidakennedy.
Fixes #40184.