Add opens in a new window to the Preview link

[rianrietveld]

Tracking ticket #23432 For some links it is useful to open in a new window. One of them is the Preview link when adding or editing a post. Then the screen reader user has to be warned the link opens in a new window.

[swissspidy]

Do we want to add a comment like hidden accessibility text? See #29748.

[rianrietveld]

Addition of translator comment

[rianrietveld]

@swissspidy last patch adds comment for translators. I checked the other places where this string occurs and there was no comment yet.

[SergeyBiryukov]

• We use accessibility text translator comment for strings like this, see [40033] for example.
• Looks like there's an extra tab character in line 60.

Looks good to me otherwise :)

[SergeyBiryukov]

Minor nitpicking: sprintf() arguments generally don't need a lot of tabs or spaces for alignment, this should be enough:

$preview_button = sprintf( '%1$s<span class="screen-reader-text"> %2$s</span>',
	esc_html( $preview_button_text ),
	/* translators: accessibility text */
	esc_html__( '(link opens in a new window)' )
);

[rianrietveld]

Change translator text and add less tabs

[SergeyBiryukov]

40185.2.patch​ looks great.

[SergeyBiryukov]

In 40422:

Administration: Add "(link opens in a new window)" as a screen reader text for "Preview" link on Edit Post screen.

Props rianrietveld.
Fixes #40185.