Twenty Seventeen: Some parts do not escape html attributes

[bor0]

There are appearances like:
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyseventeen/footer.php#L25
https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentyseventeen/template-parts/navigation/navigation-top.php#L12

_e() in these cases should actually be esc_attr_e() to ensure the translated string gets escaped for an HTML attribute context, because the translated string from another language could potentially have a character that would need to be escaped.

[iandunn]

Here are future-proof links to the lines in question:

• twentyseventeen/footer.php#L25
• twentyseventeen/navigation-top.php#L12

( linking to trunk is problematic, because those line numbers will invariably change in the future, and anyone who wants to look at the links will have to spend extra time to find the original ones )

[SergeyBiryukov]

In 40311:

Twenty Seventeen: Use esc_attr_e() for translatable strings in HTML attributes.

Props bor0.
Fixes #40216.

[SergeyBiryukov]

Reopening for 4.7.4 consideration.

[swissspidy]

In 40374:

Twenty Seventeen: Use esc_attr_e() for translatable strings in HTML attributes.

Props bor0.
Fixes #40216.

Merges [40311] to the 4.7 branch.