WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#40480 closed defect (bug) (fixed)

Cursor position bug when updating WPView shortcode in 4.7.4 RC

Reported by: bduclos Owned by: azaozz
Milestone: 4.7.4 Priority: normal
Severity: normal Version: 4.8
Component: Editor Keywords:
Focuses: javascript Cc:

Description

Using WP 4.7.4 RC, when updating a gallery/video/audio shortcode, the cursor is placed at the bottom of the editor which in some cases could result in the editor jumping to the bottom. Up to 4.7.3, after updating a shortcode its view was still selected.

Attachments (1)

40480.patch (1.1 KB) - added by azaozz 4 months ago.

Download all attachments as: .zip

Change History (8)

#1 @swissspidy
4 months ago

  • Owner set to azaozz
  • Status changed from new to assigned

The relevant change: #40305 ([40419]).

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


4 months ago

@azaozz
4 months ago

#3 @azaozz
4 months ago

In 40480.patch:

  • After updating a wpview instance, select the node again. The selection is lost when the editor is blurred (when opening the media modal, etc.).
  • Fix hiding the toolbar on blur.

#5 @azaozz
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 40481:

TinyMCE: Fix cursor position after updating a wpview node. Fix hiding the inline toolbar on editor blur.

Props iseulde, azaozz.
Fixes #40480 for trunk.

#6 @azaozz
4 months ago

  • Milestone changed from Awaiting Review to 4.7.4
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for the 4.7 branch.

#7 @azaozz
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 40482:

TinyMCE: Fix cursor position after updating a wpview node. Fix hiding the inline toolbar on editor blur.

Props iseulde, azaozz.

Merges [40481] to the 4.7 branch.
Fixes #40480.

Note: See TracTickets for help on using tickets.