WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#40982 closed defect (bug) (fixed)

Permalink Settings: custom structure field keyboard trap

Reported by: afercia Owned by: afercia
Milestone: 4.8.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch fixed-major
Focuses: accessibility Cc:
PR Number:

Description

In the Permalink Settings string, there's the same keyboard trap that as fixed in #40515 for the General settings date/time custom format fields:

When using a keyboard and trying to set a custom permalink structure, the related radio button gets automatically selected and there's basically no way to select a radio button other than the custom format one. For more details, please see #40515

Attachments (1)

40982.diff (566 bytes) - added by afercia 2 years ago.

Download all attachments as: .zip

Change History (6)

@afercia
2 years ago

#1 @afercia
2 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 4.8.1

40982.diff uses the same fix used in [40568] changing focus to click input. Also changes attr() to prop() as recommended for the checked property.

#2 @afercia
2 years ago

  • Owner set to afercia
  • Resolution set to fixed
  • Status changed from new to closed

In 40897:

Accessibility: Avoid a keyboard trap on the permalink custom structure setting.

Using the focus event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.

Also changes attr() to prop() as recommended for a checked` property.

Fixes #40982.

#3 @afercia
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.8.1 consideration.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 years ago

#5 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41024:

Accessibility: Avoid a keyboard trap on the permalink custom structure setting.

Using the focus event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.

Also changes attr() to prop() as recommended for a checked property.

Props afercia.
Fixes #40982.

Merges [40897] to the 4.8 branch.

Note: See TracTickets for help on using tickets.