themes.php search form doesn't work when submitted

[boonebgorges]

wp-admin/themes.php has a live search powered by Backbone. But if you enter a term and hit 'Enter', forcing a proper form submit, you're led back to themes.php *without* the search URL param being filled in.

Could we do one of the following?

1. Prevent form submission here, either by preventDefault() on submit, or by rejecting the Enter key
2. Add name="search" to the live search input attributes, so that form submission works normally

Previously: #34881 - cc @afercia

[afercia]

@boonebgorges I can't reproduce on previous 4.7 where the form submission seems correctly prevented. Maybe something missed with recent changes in 4.8.

[boonebgorges]

@afercia [40572] added a <form> element around the input. In 4.7, there was no form, so hitting Enter didn't do anything.

[afercia]

I guess because in 4.7 there wasn't a <form> element wrapping the search field, see [40572]  😬

[afercia]

@boonebgorges 41803.diff​ should fix it, mind a quick test? Thanks!

[boonebgorges]

@afercia Yes, this works for me.

[afercia]

In 41337:

Themes: Prevent the Themes search field default action after [40572].

Props boonebgorges.
Fixes #41803.