WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 7 months ago

#41974 closed defect (bug) (fixed)

Use consistent translator comments for strings with placeholders

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch needs-testing
Focuses: Cc:

Description

Some of the recent Customizer and Widgets commits have translators comments like this:

/* translators: placeholder is link to user profile */

They should be changed to the canonical form::

/* translators: %s: link to user profile */

Attachments (2)

41974.diff (2.4 KB) - added by Rahmohn 4 years ago.
41974.2.diff (8.2 KB) - added by danieltj 4 years ago.
Changed all instances of 'translators: placeholder'

Download all attachments as: .zip

Change History (9)

@Rahmohn
4 years ago

@danieltj
4 years ago

Changed all instances of 'translators: placeholder'

#1 @danieltj
4 years ago

  • Keywords has-patch needs-testing added; needs-patch good-first-bug removed

I've done a find all for all instances of translators: placeholder in Core.

41974.2.diff is everything I could find.

This ticket was mentioned in Slack in #core by danieltj. View the logs.


4 years ago

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41640:

I18N: Use a consistent pattern for translator comments for placeholders in Customizer and widget strings.

Props danieltj, Rahmohn.
Fixes #41974.

#4 @SergeyBiryukov
4 years ago

In 41641:

I18N: Use a consistent pattern for translator comments for placeholders in wp-admin/includes/dashboard.php.

See #41974.

#5 @SergeyBiryukov
4 years ago

In 42006:

I18N: Use a consistent pattern for translator comments for placeholders in some more Customizer strings.

See #41974.

#6 @SergeyBiryukov
4 years ago

In 42014:

I18N: Use a consistent pattern for translator comments for placeholders in the string added in [42013].

See #41974.

#7 @Hareesh Pillai
7 months ago

#40775 was marked as a duplicate.

Note: See TracTickets for help on using tickets.