Incorrect use of plural in script-loader.php

[tobifjellner]

The version of script-loader.php currently in 4.9 beta contains seems to use
__() where _n() is needed:

'mejs.time-jump-forward'   => array( __( 'Jump forward 1 second' ), __( 'Jump forward %1 seconds' ) ),

'mejs.time-skip-back'      => array( __( 'Skip back 1 second' ), __( 'Skip back %1 seconds' ) ),

'mejs.ad-skip-info'        => array( __( 'Skip in 1 second' ), __( 'Skip in %1 seconds' ) ),

[swissspidy]

_n() can only be used when you know the amount you're dealing with at this point of time. However, these strings are used in JavaScript context and and the amount is not known.

It's not ideal, but until we have something like #20491 in core, we have to live with such exceptions.

[rafa8626]

@tobifjellner MEJS takes care of that translation already in terms of the plurals, so that's why there's no need for the use of the other method as @swissspidy mentioned

[SergeyBiryukov]

These strings had translator comments added in [38150] and accidentally removed in [41198].

That said, it looks like these strings are no longer used by MediaElement.js and could be removed from script-loader.php. When it's done, #37453 can be closed as well.

[metodiew]

Based on @SergeyBiryukov's comment, removing the strings would be enough. Given the fact of the amount of internet we have during the WCEU Contributor day, was able to upload only this file. Twice for some reason, I guess the WiFi reconnection.

Are they any other strings that need to be updated/removed or that would be enough? Thanks in advance!

[tobifjellner]

These were the strings I reacted to during translation of the new strings, back then.
I haven't combed through the code, though.

[SergeyBiryukov]

In 43345:

I18N: Remove unused MediaElement.js strings.

Props metodiew.
See #42139. Fixes #37453.

[SergeyBiryukov]

Keeping the ticket open for now to see if there are any other old strings that should be removed.

[pento]

No other strings have come up, closing.

[SergeyBiryukov]

In 47094:

I18N: Synchronize MediaElement.js translation strings with the currently bundled version.

Some strings were previously removed in [43345] and accidentally reintroduced in [44163].

Props ramiy.
Fixes #49249. See #42139, #37453.