WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 8 days ago

#42537 assigned defect (bug)

Remove title attributes: wp-login.php

Reported by: SergeyBiryukov Owned by: afercia
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.9
Component: Login and Registration Keywords: has-patch title-attribute
Focuses: accessibility Cc:

Description

Background: #34625

On Multisite, the title attribute in login_header() is different from the link text and has some meaning.

<a href="http://ms.wordpress.dev/" title="Network Title" tabindex="-1">Site Title</a>

On single site, however, the title attribute just duplicates the link text and is redundant:

<a href="http://wordpress.dev/" title="Powered by WordPress" tabindex="-1">Powered by WordPress</a>

Most of the title attributes are already removed from core via #24766 and related tickets. We should consider removing this one as well, either completely or only if it duplicates the link text.

The login_headertitle filter could either be deprecated or repurposed to filter the link text instead.

Attachments (2)

42537.diff (612 bytes) - added by chetan200891 14 months ago.
Created patch to remove title attribute.
42537.2.diff (1.8 KB) - added by pratikkry 2 weeks ago.
deprecate login_headertitle filter and remove $login_header_title

Download all attachments as: .zip

Change History (16)

@chetan200891
14 months ago

Created patch to remove title attribute.

#1 @chetan200891
14 months ago

  • Keywords has-patch added

I've attached the patch 42537.diff.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


14 months ago

#3 @afercia
14 months ago

  • Milestone changed from Awaiting Review to 5.0

See also #42632

#4 @afercia
6 months ago

  • Keywords title-attribute added

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


4 months ago

#6 @afercia
4 months ago

  • Milestone changed from 5.0 to 4.9.9

Discussed during today's accessibility bug-scrub an agreed we'd like to propose this for 4.9.9 consideration.

#7 @pento
4 months ago

  • Milestone changed from 4.9.9 to 5.0.1

#8 @pento
6 weeks ago

  • Milestone changed from 5.0.1 to 5.0.2

#9 @pento
5 weeks ago

  • Milestone changed from 5.0.2 to 5.0.3

#10 @audrasjb
4 weeks ago

  • Keywords commit added

#11 @ocean90
2 weeks ago

  • Milestone changed from 5.0.3 to 5.1

Looks like the login_headertitle should be deprecated as well. I guess any reference to $login_header_title can be removed as well to simplify the code.

Last edited 2 weeks ago by ocean90 (previous) (diff)

@pratikkry
2 weeks ago

deprecate login_headertitle filter and remove $login_header_title

#12 @afercia
12 days ago

  • Keywords commit removed
  • Milestone changed from 5.1 to 5.2

The 5.1 release beta 1 is today, the patch probably needs a refresh and deprecation of filters needs to happen early in a release cycle. Punting to 5.2.

Last edited 8 days ago by afercia (previous) (diff)

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


11 days ago

#14 @afercia
11 days ago

  • Owner set to afercia
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.