Text Widget: hard-coded width/height attributes are stripped from iframes

[dubaicarmelschool]

hi when i update my WordPress 4.9 my exiting iframe size in text widget not working.please find my ​http://dubaicarmelschool.com/ and iframe code below:
<iframe src="sshow/show.html" border="0" width="700" height="400"style="border: 0; margin-left: -120px; margin-right: -0px; margin-top: -9px; margin-bottom: -0px;"></iframe>

[dubaicarmelschool]

text widget iframe output

[westonruter]

The width and height are getting removed for the sake of getting embeds to resize properly. See [42001] and #42203.

I can see that this logic needs to be prevented for any elements that are hard-coded with dimensions. We need to limit the replacements to iframes and other media that come from external embeds

@dubaicarmelschool in the immediate term, please add your iframe code to a Custom HTML widget instead. This will bypass the stripping of the width and height attributes.

[westonruter]

The approach we take in a patch could be to replace all width/height attributes with placeholders prior to doing embeds, and then restore them after the embeds are done.

[programmin]

The same thing happens whenever you paste a Google Calendar code into the code, eg.

<iframe src="thecalendar.google.comURL" style="border: 0" width="100%" height="600" frameborder="0" scrolling="no"></iframe>

Height is removed, iframe is not very big, as in that screenshot.

[westonruter]

I think what should be done is the following: any heights or widths in the original text should get replaced with placeholders before running the embed logic. Then after embedding logic is done, and the dimensions are stripped out, the placeholders can be swapped back with their original values. This will ensure any user-supplied dimensions are kept intact.

[dd32]

Bumping to 4.9.3 due to 4.9.2s release

[programmin]

I'm surprised there was no mention of using HEIGHT="NUMBER" in capitals to make the Wordpress match and replace not take away all the height. I would think this should be a top, bolded item in the release notes for wp4.9 - if you have iframe that you still want to have height, make sure you edit it and CAPITALIZE height after upgrading.

[desrosj]

Punting to 4.9.4.

[programmin]

At the very least shouldn't the release notes say users need to capitalize HEIGHT in iframes if they want to actually see it all?

[dd32]

Bumping, 4.9.4 has been released.

[audrasjb]

Hi @westonruter

I tried a workaround for this ticket in 42695.diff.
This patch clearly needs dev-feedback.

Cheers,
Jb

[audrasjb]

Avoid to strip dimensions from iframes in text widget embed logic

[audrasjb]

Bumping to 4.9.6 due to 4.9.5 beta release.

[programmin]

Not seeing any mention of this in ​https://codex.wordpress.org/Version_4.9

If this is not changing there should be a note that every widget with an iframe tag should have capitalized height= if you want it to actually have height.