Custom HTML widget validation error

[markemark]

Hi there, recently updated to latest wordpress version 4.9.1
Now custom html widget, which works, now I cannot save, says there is a validation error, so I cannot edit and save.

Here is the html (with external javascript)

<div class="cta_addtocart">
<h3>Sober Intervention Training</h3>
<p>(Course Delivered in English)</p>
<p class="space">Just 20 places in total</p>

<p class="days">3 DAYS - Friday 16th February 2018 - Sunday 18th February 2018</p>

<p class="where">Tegnérgatan 24, 113 59 Stockholm, Sweden</p>

<script type='text/javascript' src='https://www.universe.com/embed2.js'></script>
[x_button type='flat' shape='rounded' size='large' href='https://www.universe.com/events/sober-academy-sober-intervention-training-tickets-9TFQX2' title='Sober Intervention Training -
 Stockholm']Get Tickets[/x_button]

</div>

I have tried with and without "type='text/javascript'" - but still error, therefore I cannot edit?

Can you please fix ?

[westonruter]

@markemark What is the validation error you are getting?

[sasiddiqui]

@markemark You are getting error due to the quotation issue on type and src. You need to define the type and src attribute in double quotes instead of single quote.

So, Your code something looks like this:

<div class="cta_addtocart">
<h3>Sober Intervention Training</h3>
<p>(Course Delivered in English)</p>
<p class="space">Just 20 places in total</p>

<p class="days">3 DAYS - Friday 16th February 2018 - Sunday 18th February 2018</p>

<p class="where">Tegnérgatan 24, 113 59 Stockholm, Sweden</p>

<script type="text/javascript" src="https://www.universe.com/embed2.js"></script>
[x_button type='flat' shape='rounded' size='large' href='https://www.universe.com/events/sober-academy-sober-intervention-training-tickets-9TFQX2' title='Sober Intervention Training -
 Stockholm']Get Tickets[/x_button]

</div>

Hope, it helps you :)

[westonruter]

It's either that or an issue with unfiltered_html. Really the use of single quotes shouldn't be an error. It should be a warning at most.

[sasiddiqui]

Convert the error to warning for single quotes instead of double quotes

[sasiddiqui]

Changed the message of the error as well.

[sasiddiqui]

Patch has been added for changing the error to warning and the message as well. Please refer:

https://core.trac.wordpress.org/attachment/ticket/42802/42802.2.patch

Previous Message:
Attribute values must be in double quotes.

Updated Message:
Attribute values should be in double quotes.

[westonruter]

@sasiddiqui Patching HTMLHint isn't going to be the right solution. Instead, the attr-value-double-quotes rule should just be removed: ​https://github.com/WordPress/wordpress-develop/blob/1c2b0762c7f1a91394c633ae812505919bd297ed/src/wp-includes/general-template.php#L3253

@markemark Please confirm which validation error message you're setting.

[sasiddiqui]

Making "attr-value-double-quotes" to false

[sasiddiqui]

@westonruter I have patched HTMLHint to make doublw quotes error to warning as i thought it should be warned to user when single quote with attributes it doesn't need to be removed.

Anyways, if you just want to remove the rule so you just make it false for now.

[westonruter]

Just waiting for @markemark to respond to confirm the issue.

[westonruter]

#42988 was marked as a duplicate.

[westonruter]

@markemark please confirm that the 42802-remove-rul.patch​ fixes the issue so we can merge into the next release.

[dd32]

Bumping to 4.9.3 due to 4.9.2s release

[sasiddiqui]

@markemark Kindly get sometime from your schedule and check 42802-remove-rul.patch either it fixes your defined issue or not.

Please provide your feedback after testing it.

Thanks

[sasiddiqui]

@westonruter Can i own this ticket?

[westonruter]

@sasiddiqui I don't think there's anything else to do here to own. I just need to commit. I would have preferred to have @markemark test it first, however.

[westonruter]

In 42531:

Code Editor: Disable attr-value-double-quotes HTMLHint rule since too strict for user input.

Using single-quoted attribute values is not in any way invalid HTML.

Amends [41376].
Props sasiddiqui.
See #12423.
Fixes #42802.

[westonruter]

In 42532:

Code Editor: Disable attr-value-double-quotes HTMLHint rule since too strict for user input.

Using single-quoted attribute values is not in any way invalid HTML.

Amends [41376].
Props sasiddiqui.
See #12423.
Fixes #42802 for 4.9 branch.