WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#43193 closed task (blessed) (fixed)

Support x+ Million active installs for plugins

Reported by: dd32 Owned by: dd32
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: needs-patch
Focuses: Cc:

Description

A few months ago WordPress.org updated the maximum number of active installs that would be shown for plugins from 1m+ to 5m+. However, core currently maxes out at 1+ million.

We should change that for consistency.

We should also ensure that the string used here supports 10m+ in the future.

Attachments (1)

43193.diff (1.7 KB) - added by dd32 5 months ago.

Download all attachments as: .zip

Change History (9)

#1 @dd32
5 months ago

Example of a plugin with >1m installs: https://wordpress.org/plugins/akismet/

@dd32
5 months ago

#2 follow-up: @dd32
5 months ago

  • Keywords has-patch added

43193.diff implements this using _nx(), however I'm not sure if that's the best method in which to do it.

Do I pass 2,000,000 or 2 to the $number field for example? (I pass 2000000, and insert 2, which seems wrong)

#3 @ocean90
4 months ago

#43520 was marked as a duplicate.

#4 in reply to: ↑ 2 @SergeyBiryukov
4 months ago

Replying to dd32:

Do I pass 2,000,000 or 2 to the $number field for example? (I pass 2000000, and insert 2, which seems wrong)

$number should be the number displayed in the string, e.g. 2, 5, or 10.

#5 @dd32
4 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 42829:

Plugins: Add support for plugins having an active_installs value larger than 1 million.
WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future.

Fixes #43193.

#6 @johnbillion
7 weeks ago

  • Keywords needs-patch added; has-patch removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

In [42829], the parameters passed to _nx() are in the wrong order.

#7 @johnbillion
7 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43178:

Plugins: Correct the parameters used when displaying plugins with more than one million active installations.

Fixes #43193

#8 @johnbillion
7 weeks ago

In 43179:

Plugins: Correct another instance of incorrect parameter ordering when displaying plugins with more than one million active installations.

See #43193

Note: See TracTickets for help on using tickets.