#43650 closed enhancement (fixed)
Add Requires PHP Version to Plugin - View Details
Reported by: | xkon | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch has-screenshots commit fixed-major servehappy |
Focuses: | administration | Cc: |
Description
It came to my attention today after making some plugin updates that when clicking on the View Details of a Plugin I couldn't find the Requires PHP
that was added on Meta.
I'm sure that it'll be handy to more people to be able to easily check PHP requirements within the popup as well before hitting the update button :].
--
I searched around trac just in case there was another ticket for this, but to no avail, sorry if this is a duplicate.
Attachments (3)
Change History (18)
#1
@
7 years ago
- Keywords has-patch has-screenshots 2nd-opinion added
43650.diff checks if there's a requires_php
and adds it to the list as seen on 43650.jpg
#3
@
7 years ago
- Keywords 2nd-opinion removed
Related: #40934, see also the screenshots starting at ticket:40934:27.
#5
@
7 years ago
- Keywords commit added
This looks good to me. I think this can go in before the other UI elements in #40934 because it is purely informational.
#7
@
7 years ago
I just did a quick review. The patch looks good, 43650.2.diff addresses some minor issues. Since the same translation string was already present before (for the WordPress version), I updated the translator comment to be the same for both occurrences (it's simply about the placeholder being a version number).
#10
@
7 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
This still needs to be backported to 4.9.6.
#12
@
7 years ago
- Owner changed from flixos90 to SergeyBiryukov
- Status changed from reopened to assigned
#14
@
7 years ago
Smart feature @xkon!
Wouldn’t the string be more translatable if it used a placeholder instead of assuming all languages want the number to come to the right of the string?
Eg instead of
_e( 'Requires PHP Version:' ); ... printf( __( '%s or higher' ), $api->requires_php );
we should have
printf( __( 'Requires PHP Version %s or higher' ), $api->requires_php );
I would think this would he more friendly to right-to-left languages, no? But that will of course add a new string to be translated, and maybe that’s not an option...
preview