Function "user_can_access_admin_page" refactor.

[rnaby]

I think this user_can_access_admin_page function should looks more clean and better this way. Also added a description of the function.

[rnaby]

The patch for the enhancement.

[rnaby]

Another improved patch. Merged some if statement and refactored.

[valentinbora]

Thanks for the patch @rnaby and sorry for the delay here. Unfortunately, the patch needs a refresh as it no longer applies cleanly onto trunk.

For reference, coding standards relevant docs:

• ​https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/
• ​https://www.php-fig.org/psr/psr-12/#51-if-elseif-else

[khag7]

I reviewed the proposed patch and compared it against the current implementation.

The proposed patch is mostly whitespace changes and merging of if statements.

For example (pseudo-code):

if( A ){
    something
}
if( B ){
    something
}

to

if( A || B ){
    something
}

The current implementation is relatively concise and correct with WordPress coding standards. There's no need for this ticket to remain open.

[SergeyBiryukov]

While I mostly agree with comment:3, I think there is some benefit in replacing these parts:

if ( current_user_can( $submenu_array[1] ) ) {
	return true;
} else {
	return false;
}

with:

return current_user_can( $submenu_array[1] );

[SergeyBiryukov]

In 48762:

Coding Standards: Simplify some parts of user_can_access_admin_page() for better readability.

Props rnaby, valentinbora, khag7.
Fixes #43848.

[SergeyBiryukov]

In 48764:

Coding Standards: Fix WPCS issues in wp-admin/includes/plugin.php.

Includes minor code layout fixes for better readability.

Props rnaby for initial patch.
See #50767, #43848.