Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#43926 closed enhancement (fixed)

Improve flow for privacy.php

Reported by: clorith's profile Clorith Owned by: iandunn's profile iandunn
Milestone: 4.9.6 Priority: normal
Severity: normal Version: 5.1
Component: Privacy Keywords: gdpr fixed-major
Focuses: ui Cc:

Description

The privacy.php currently in trunk has a button to create a new privacy policy page.

My expectation is that once I create a new page, and am expected to review and edit this page, I should be taken directly to the post editor.

Currently the page refreshes and a notice shows up:

Your Privacy Policy page created successfully. You’ll want to review and edit your policy next.

This text is also a bit confusing, when reading it, I see that my privacy policy page is successfully created. Fantastic, in my head I'm done, I've done what I need to do.

The next part, it says I will want to review and edit it, to me this means I can make changes if I'd like, but it's not a requirement, this would be solved by putting you into the editor straight away and thus removing any uncertainty about the need for editing or not.

Attachments (2)

43926.diff (1.8 KB) - added by xkon 6 years ago.
43926.2.diff (1.3 KB) - added by xkon 6 years ago.
redirect after create page

Download all attachments as: .zip

Change History (18)

#1 @xkon
6 years ago

This makes total sense. It would actually be inline also with how the users are used to Add New since they're always going straight into the editor.

This ticket was mentioned in Slack in #gdpr-compliance by xkon. View the logs.


6 years ago

#3 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 4.9.6

#4 @ocean90
6 years ago

It's also confusing that the button doesn't get removed once you have created the page. Each time you click the button a new page is created. Doesn't fill right.

Having two primary buttons that close is also quite unusual on admin screens.

@xkon
6 years ago

#5 @xkon
6 years ago

In 43926.diff you are redirected to the post editor after you Create a page. Also it hides the Create option if there's already a policy page selected.

#6 @xkon
6 years ago

  • Keywords has-patch 2nd-opinion added

This ticket was mentioned in Slack in #gdpr-compliance by xkon. View the logs.


6 years ago

@xkon
6 years ago

redirect after create page

#8 @xkon
6 years ago

Almost instant patch update. Sorry for that. 43926.2.diff takes care of the redirection for the time being.

@ocean90 : I remembered that we had talked about having the 2 options there permanently ( select + create ) even if a page is selected just for the means of a user being able to create 'yet another page' since it's not so clear that you have to clear your selection from the dropdown first for the Create button to re-appear if that makes sense.

This ticket was mentioned in Slack in #core by xkon. View the logs.


6 years ago

#10 @desrosj
6 years ago

  • Type changed from defect (bug) to enhancement

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


6 years ago

This ticket was mentioned in Slack in #gdpr-compliance by desrosj. View the logs.


6 years ago

#13 @iandunn
6 years ago

  • Owner set to iandunn
  • Resolution set to fixed
  • Status changed from new to closed

In 43160:

Privacy: Redirect to newly created Privacy Policy page to improve UX.

Previously the user was shown a message that the page was created, but might not understand that they still need to visit the page and publish it. Redirecting them to the page makes it more obvious that additional steps are involved.

Props Clorith, xkon, azaozz.
Fixes #43926.

#14 @iandunn
6 years ago

  • Keywords fixed-major added; has-patch 2nd-opinion removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to 4.9.

#15 @azaozz
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43161:

Privacy: Redirect to newly created Privacy Policy page to improve UX.

Previously the user was shown a message that the page was created, but might not understand that they still need to visit the page and publish it. Redirecting them to the page makes it more obvious that additional steps are involved.

Props Clorith, xkon, azaozz.
Merges [43160] to the 4.9 branch.
Fixes #43926.

#16 @desrosj
6 years ago

  • Component changed from Administration to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.