WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 10 months ago

#44103 new feature request

change the type attribute of #menu_order from 'text' to 'number'

Reported by: tmatsuur Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.9.5
Component: General Keywords: has-patch ux-feedback
Focuses: Cc:

Description

Currently, when focus shifts to the input box of menu_order in the situation that the IME is turned on, an extra operation such as inputting a numerical value after turning off the IME is necessary.
I would like to improve on this.

Now:

<input name="menu_order" type="text" size="4" id="menu_order" value="<?php echo esc_attr( $post->menu_order ); ?>" />

Change:

<input name="menu_order" type="number" id="menu_order" value="<?php echo esc_attr( $post->menu_order ); ?>" />

Also, please add a style to specify the width.

Attachments (1)

44103.diff (1.5 KB) - added by soulseekah 2 years ago.
type="text" to type="number" on menu_order inputs

Download all attachments as: .zip

Change History (8)

@soulseekah
2 years ago

type="text" to type="number" on menu_order inputs

#1 follow-up: @soulseekah
2 years ago

  • Keywords has-patch ux-feedback added

Thank you for bring this to our attention. Patch attached.

#2 in reply to: ↑ 1 @tmatsuur
2 years ago

Replying to soulseekah:

Thank you for bring this to our attention. Patch attached.

Thank you for attached the patch.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


10 months ago

#4 @melchoyce
10 months ago

Could someone add some before/after screenshots? That'll help folks reviewing to understand the context.

#5 @tmatsuur
10 months ago

https://elearn.jp/img/44103-fig.png

I'm not sure how to attach an image. Is this all right?

On the left is version 4.9.12. After clicking the menu order input box, type 5.

The right side is version 5.3.0. Clicking the menu order input box automatically switches the IME from Japanese mode to English mode.

#6 follow-up: @melchoyce
10 months ago

Thanks @tmatsuur. Just to clarify, is that 5.3.0 with 44103.diff applied?

#7 in reply to: ↑ 6 @tmatsuur
10 months ago

Replying to melchoyce:

Thanks @tmatsuur. Just to clarify, is that 5.3.0 with 44103.diff applied?

Oops, sorry.

Here is the image with the patch applied.

https://elearn.jp/img/44103-fig-2.png

Note: See TracTickets for help on using tickets.