WordPress.org

Make WordPress Core

Opened 13 months ago

Last modified 2 months ago

#44968 new defect (bug)

Header Text color option doing two jobs, so both suffer

Reported by: joyously Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Customize Keywords: dev-feedback
Focuses: Cc:
PR Number:

Description

There are two issues, both of which have been addressed before. #23761, #22498

The Header Text color option and the Display Site Title and Tagline option use the same storage space (theme_mod), so there is no way to hide the title and use the color for other header text, and when the title is unhidden the color is (sort of) the default.

Steps to reproduce:

  1. In Customizer, note the header text color for comparison later.
  2. Hide the site title.
  3. Save and exit the Customizer.
  4. Open Customizer and unhide the site title.
  5. Look at the header text color and compare to value from step 1.

What I expect:

  1. The header text color could be used for other header text besides the site title. Hiding the title should not hide the color selection.
  2. The color set before the title was hidden should be restored when the title is unhidden.

What actually happens:

  1. The color option is used to indicate the visibility of the site title, so the color is set to 'blank'.
  2. Other text in the header cannot be styled with the header text color if the site title is hidden.
  3. When the site title is unhidden, the header text color option shows a color for the swatch that is the default color, but the text input box is empty and the color indicator shows black (as if it were 0).

Or just set the color of the header text, hide it, unhide it, and the color you chose is gone.

I think it should be two separate options for color and hiding. I don't know how that would affect backward compatibility, but it is the best solution.

Attachments (2)

44968-header-text-color.jpg (59.5 KB) - added by joyously 13 months ago.
Note the white swatch (and text), the empty input box, and the black color indicator.
customizer_issue.webm (3.8 MB) - added by mukesh27 13 months ago.

Change History (5)

@joyously
13 months ago

Note the white swatch (and text), the empty input box, and the black color indicator.

#1 @joyously
13 months ago

Ignore this line:

Or just set the color of the header text, hide it, unhide it, and the color you chose is gone.

#2 @mukesh27
13 months ago

  • Component changed from Options, Meta APIs to Customize
  • Keywords dev-feedback added

@joyously, Yes it's bug. it will persist when we close Customizer panel otherwise color field value not removed and it working fine. check attached video for more information.

Last edited 13 months ago by mukesh27 (previous) (diff)

This ticket was mentioned in Slack in #themereview by joyously. View the logs.


2 months ago

Note: See TracTickets for help on using tickets.