WordPress.org

Make WordPress Core

#45559 closed defect (bug) (duplicate)

W3C CSS Validator error in some core CSS files

Reported by: man4toman Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots
Focuses: ui, coding-standards Cc:
PR Number:

Description

There is some error related to transition delay value. In some core CSS files the delay values sets on "0" and it's incorrect, it must be "0s".

The related patches is for these files:

wp-admin/css/common.css
wp-admin/css/themes.css
wp-includes/css/dashicons.css

Attachments (6)

common.css.patch (354 bytes) - added by man4toman 11 months ago.
common.css
themes.css.patch (403 bytes) - added by man4toman 11 months ago.
themes.css
dashicons.css.patch (398 bytes) - added by man4toman 11 months ago.
dashicons.css
W3C CSS Validator.png (24.0 KB) - added by man4toman 11 months ago.
W3C CSS Validator
all.patch (1.3 KB) - added by man4toman 11 months ago.
All
45559.patch (2.1 KB) - added by mukesh27 11 months ago.
@man4toman, updated patch as you have missed rtl css files.

Download all attachments as: .zip

Change History (18)

@man4toman
11 months ago

common.css

@man4toman
11 months ago

themes.css

@man4toman
11 months ago

dashicons.css

@man4toman
11 months ago

W3C CSS Validator

#1 @swissspidy
11 months ago

Would you mind creating the patches from the root of your WordPress development directory so that patch files contain the full paths? Makes it easier to apply the changes locally :-)

@man4toman
11 months ago

All

#2 @man4toman
11 months ago

@swissspidy

Hmm, do I understand you? The new patch contain all files paths.

Last edited 11 months ago by man4toman (previous) (diff)

#3 @netweb
11 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.0.1
  • Version 5.0 deleted

@mukesh27
11 months ago

@man4toman, updated patch as you have missed rtl css files.

#4 follow-up: @man4toman
11 months ago

@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.

Then I think the first patch file is OK.

Last edited 11 months ago by man4toman (previous) (diff)

#5 in reply to: ↑ 4 ; follow-up: @netweb
11 months ago

Replying to man4toman:

@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.

This is correct, the RTL CSS files are automatically generated by the build tools

Then I think the first patch file is OK.

Correct, patch all.patch is all that is required

#6 @man4toman
11 months ago

@netweb
Thanks, I remember what you said to me :)

#7 in reply to: ↑ 5 @mukesh27
11 months ago

Thanks @netweb. i don't know how rtl css generate.

Replying to netweb:

Replying to man4toman:

@mukesh27 Thanks but I remember @netweb told me there isn't need to patch RTL codes because they use RTLCSS to generate RTL files, so I didn't add codes for RTL.

This is correct, the RTL CSS files are automatically generated by the build tools

Then I think the first patch file is OK.

Correct, patch all.patch is all that is required

Last edited 11 months ago by mukesh27 (previous) (diff)

#8 @swissspidy
11 months ago

@mukesh27 You don‘t have to do a thing there :-)

#9 @pento
11 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#10 @SergeyBiryukov
11 months ago

  • Component changed from General to Administration
  • Focuses ui added

#11 @pento
11 months ago

  • Milestone changed from 5.0.2 to 5.0.3

#12 @desrosj
10 months ago

  • Keywords has-patch commit removed
  • Milestone 5.0.3 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Hi @man4toman,

Thanks for working on this! It appears that this issue was fixed in [42689], though. The changes for #43195 will be released in WordPress 5.1.

Note: See TracTickets for help on using tickets.