WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 17 months ago

Last modified 4 months ago

#43195 closed enhancement (fixed)

dashicons fail w3c css validation

Reported by: manuel_84 Owned by: SergeyBiryukov
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.9.2
Component: Administration Keywords: has-patch
Focuses: ui, coding-standards Cc:

Description

/wp-includes/css/dashicons.min.css?ver=4.9.2

line 2: .dashicons, .dashicons-before:before

0 is not a value for transition : color 0.1s ease-in 0

Attachments (1)

43195.diff (427 bytes) - added by chetan200891 18 months ago.
Created patch to drop the transition-delay completely from dashicons.css

Download all attachments as: .zip

Change History (14)

#1 @manuel_84
18 months ago

fix by adding a "s" after the final 0:

transition : color 0.1s ease-in 0s

#2 @GaryJ
18 months ago

Thank you @manuel_84 for opening your first ticket :-)

Good catch with the bug.

An alternative solution would be to drop the transition-delay completely since the default is 0s anyway:

transition: color 0.1s ease-in;

@chetan200891
18 months ago

Created patch to drop the transition-delay completely from dashicons.css

#3 @SergeyBiryukov
18 months ago

  • Component changed from Bundled Theme to Administration
  • Focuses template removed
  • Milestone changed from Awaiting Review to 5.0

#4 @chetan200891
18 months ago

  • Keywords has-patch added

#5 @SergeyBiryukov
17 months ago

Per https://developer.mozilla.org/en-US/docs/Web/CSS/time:

Although unitless zero is allowed for <length>s, it's invalid for <time>s.

#6 @SergeyBiryukov
17 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 42689:

Administration: Remove erroneous transition-delay values from CSS files.

Although unitless zero is allowed for <length> CSS data type, it's invalid for <time> data type.

Props chetan200891, manuel_84, GaryJ.
Fixes #43195.

#7 @SergeyBiryukov
17 months ago

Created a GitHub issue for genericons.css: https://github.com/Automattic/Genericons/issues/109, since it's bundled with Twenty Fifteen and Twenty Sixteen.

#8 @SergeyBiryukov
15 months ago

#43769 was marked as a duplicate.

#9 @pento
9 months ago

  • Milestone changed from 5.0 to 5.1

#10 @desrosj
7 months ago

#45559 was marked as a duplicate.

#11 @swissspidy
5 months ago

#46182 was marked as a duplicate.

This ticket was mentioned in Slack in #core by malae. View the logs.


4 months ago

#13 @desrosj
4 months ago

In 45097:

Administration: Remove unnecessary transition-delay values from Dashicons.

A unitless 0 value for a <time> CSS data type was reintroduced in [45040]. This is allowed for <length> data types, but is invalid for <time>.

See #43195.
Fixes #46774.

Note: See TracTickets for help on using tickets.